Spec URL: http://verdurin.fedorapeople.org/reviews/MACS/MACS.spec SRPM URL: http://verdurin.fedorapeople.org/reviews/MACS/MACS-1.4.0-1.fc16.src.rpm Description: Next generation parallel sequencing technologies made chromatin immunoprecipitation followed by sequencing (ChIP-Seq) a popular strategy to study genome-wide protein-DNA interactions, while creating challenges for analysis algorithms. We present Model-based Analysis of ChIP-Seq (MACS) on short reads sequencers such as Genome Analyzer (Illumina / Solexa). MACS empirically models the length of the sequenced ChIP fragments, which tends to be shorter than sonication or library construction size estimates, and uses it to improve the spatial resolution of predicted binding sites. MACS also uses a dynamic Poisson distribution to effectively capture local biases in the genome sequence, allowing for more sensitive and robust prediction. MACS compares favorably to existing ChIP-Seq peak-finding algorithms, is publicly available open source, and can be used for ChIP-Seq with or without control samples.
Update for 1.4.1 release: http://verdurin.fedorapeople.org/reviews/MACS/MACS.spec http://verdurin.fedorapeople.org/reviews/MACS/MACS-1.4.1-1.fc16.src.rpm
I suggest to ask the developers to put their releases in a more standard directory, like %{name}-%{version}, or at least remove the hash from its name. You might want to use this if clause: http://fedoraproject.org/wiki/Packaging:Python#Macros macs.1* should probably be macs.1.* You could be a bit more specific in the files section, stating something like: %{python_sitelib}/%{name}* %{python_sitelib}/%{name}-%{version}-py*.egg
Any news here?
New version addressing the issues in https://bugzilla.redhat.com/show_bug.cgi?id=716400#c2 at: http://verdurin.fedorapeople.org/reviews/MACS/MACS.spec http://verdurin.fedorapeople.org/reviews/MACS/MACS-1.4.1-2.fc17.src.rpm While I want to have EPEL5/6 branches, I don't like too many conditionals, so I've made a separate branch in Git for Fedora vs. EPEL. The version up for review is the Fedora one.
The version you uploaded still has all the elements necessary for EPEL5. I'd recommend NOT to maintain separate spec file, since the obsolete elements don't hurt. They're just not useful if you packaged for Fedora only. Please preserve the timestamp of the manpage by adding -p to the install command. defattr is not necessary (since EPEL4). "macs.1* should probably be macs.1.*" -- I must apologize on this one: Your version was perfectly fine and mine is not.
I haven't been working in this field for over two years now, so it would be better for someone else to maintain this package, if there is interest.