Bug 716440 - [PATCH] Set custom variables with custom-set-variables instead of setq
Summary: [PATCH] Set custom variables with custom-set-variables instead of setq
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: emacs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karel Klíč
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-24 13:11 UTC by Ville Skyttä
Modified: 2013-03-03 23:02 UTC (History)
3 users (show)

Fixed In Version: 23.3-7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-29 21:34:04 UTC
Type: ---

Attachments (Terms of Use)
Use custom-set-variables for customizable things in .emacs (818 bytes, patch)
2011-06-24 13:11 UTC, Ville Skyttä 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Ville Skyttä 2011-06-24 13:11:43 UTC 
Created attachment 509751 [details]
Use custom-set-variables for customizable things in .emacs

Setting custom variables with setq causes the values set with customize-variable to be ignored if the setq's appear after custom-set-variables, and just causes confusion (duplicate settings) if set before the custom-set-variables block.

The attached patch switches to use custom-set-variables for customizable ones (inhibit-default-init, diff-switches, require-final-newline) in .emacs.  Let me know if you'd like me to commit and build this for devel.
Comment 1 Karel Klíč 2011-06-29 12:46:48 UTC 
Looks good. Feel free to commit and build this. Thanks.
Note You need to log in before you can comment on or make changes to this bug.