Hide Forgot
Spec URL: http://rlandmann.fedorapeople.org/packages/perl-HTML-FormatText-WithLinks.spec SRPM URL: perl-HTML-FormatText-WithLinks-0.14-2.fc15.src.rpm Description: HTML::FormatText::WithLinks takes HTML and turns it into plain text but prints all the links in the HTML as footnotes. By default, it attempts to mimic the format of the lynx text based web browser's --dump option. rpmlint output: $ rpmlint SPECS/perl-HTML-FormatText-WithLinks.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/perl-HTML-FormatText-WithLinks-0.14-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/perl-HTML-FormatText-WithLinks-0.14-2.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. scratch build on Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3162574
Sorry: SRPM URL here: http://rlandmann.fedorapeople.org/packages/perl-HTML-FormatText-WithLinks-0.14-2.fc15.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3170492 $ rpmlint -v -i * perl-HTML-FormatText-WithLinks.src: I: checking perl-HTML-FormatText-WithLinks.src: I: checking-url http://search.cpan.org/dist/HTML-FormatText-WithLinks/ (timeout 10 seconds) perl-HTML-FormatText-WithLinks.src: I: checking-url http://www.cpan.org/authors/id/S/ST/STRUAN/HTML-FormatText-WithLinks-0.14.tar.gz (timeout 10 seconds) perl-HTML-FormatText-WithLinks.noarch: I: checking perl-HTML-FormatText-WithLinks.noarch: I: checking-url http://search.cpan.org/dist/HTML-FormatText-WithLinks/ (timeout 10 seconds) perl-HTML-FormatText-WithLinks.spec: I: checking-url http://www.cpan.org/authors/id/S/ST/STRUAN/HTML-FormatText-WithLinks-0.14.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Looks fine so far. Formal review will follow.
--------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 264a1436883d20b81e669c65a1f97367 HTML-FormatText-WithLinks-0.14.tar.gz 264a1436883d20b81e669c65a1f97367 HTML-FormatText-WithLinks-0.14.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permisseable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ----------------
Many thanks for the review Mario! New Package SCM Request ======================= Package Name: perl-HTML-FormatText-WithLinks Short Description: HTML to text conversion with links as footnotes Owners: rlandmann Branches: f14 f15 el6 InitialCC: perl-sig
Already in Fedora: https://admin.fedoraproject.org/pkgdb/acls/name/perl-HTML-FormatText-WithLinks
Gah. Sorry; don't know how I missed it :(