Bug 716777 - Review Request: perl-Crypt-RC4 - Perl implementation of the RC4 encryption algorithm
Summary: Review Request: perl-Crypt-RC4 - Perl implementation of the RC4 encryption al...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-27 03:18 UTC by Mathieu Bridon
Modified: 2011-07-05 08:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-05 08:53:55 UTC
Type: ---
Embargoed:
emmanuel: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Mathieu Bridon 2011-06-27 03:18:27 UTC
Spec URL: http://bochecha.fedorapeople.org/packages/perl-Crypt-RC4.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Crypt-RC4-2.02-1.fc16.src.rpm
Description: 
A simple implementation of the RC4 algorithm, developed by RSA Security,
Inc. Here is the description from RSA's website:

RC4 is a stream cipher designed by Rivest for RSA Data Security (now RSA
Security). It is a variable key-size stream cipher with byte-oriented
operations. The algorithm is based on the use of a random permutation. Analysis
shows that the period of the cipher is overwhelmingly likely to be greater than
10100. Eight to sixteen machine operations are required per output byte, and
the cipher can be expected to run very quickly in software. Independent analysts
have scrutinized the algorithm and it is considered secure.


Output of rpmlint is clean:
$ rpmlint -i ./perl-Crypt-RC4.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint -i /var/lib/mock/fedora-rawhide-x86_64/result/perl-Crypt-RC4-2.02-1.fc16.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Emmanuel Seyman 2011-07-02 15:02:17 UTC
Taking.

Comment 2 Emmanuel Seyman 2011-07-02 15:30:50 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3175738

 [x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default is used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
4ca59a7e58ac9597c3b4f3f46ea22629  Crypt-RC4-2.02.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3175738
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
No tests included with module. :-(

APPROVED.

Comment 3 Mathieu Bridon 2011-07-04 03:10:44 UTC
Thanks Manu!

New Package SCM Request
=======================
Package Name: perl-Crypt-RC4
Short Description: Perl implementation of the RC4 encryption algorithm
Owners: bochecha
Branches: f15 el6
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2011-07-04 14:34:02 UTC
Git done (by process-git-requests).

Comment 5 Mathieu Bridon 2011-07-05 08:53:55 UTC
Package built and update submitted in all requested branches (plus rawhide).

Thanks everyone!


Note You need to log in before you can comment on or make changes to this bug.