Description of problem: No tests are run when nspr is built. Version-Release number of selected component (if applicable): 4.8.8-1 How reproducible: always Steps to Reproduce: 1. Download the latest nspr srpm from Koji into ~/rpmbuild/SRPM 2. cd ~/rpmbuild/SRPM; rpm -ihv nspr-4.8.8-1.fc16.src.rpm 3. cd ~/rpmbuild/SPECS; rpmbuild --rebuild nspr-4.8.8-1.fc16.src.rpm' (or execute 'fedpkg local' from the nspr checkout directory) Actual results: No tests are run Expected results: the test suite is run Additional info: wtc informs me that one can run either the shell script mozilla/nsprpub/pr/tests/runtests.sh or its Perl script version mozilla/nsprpub/pr/tests/runtests.pl. The latter is reportedly better at aborting a timed-out test.
Like we do for nss.spec we could add to nspr.spec: %check # Run test suite. perl ./mozilla/nsprpub/pr/tests/runtests.pl 2>&1 | tee output.log TEST_PASSED=`grep -c Passed ./output.log` TEST_FAILURES=`grep -c FAILED ./output.log` || : if [ $TEST_FAILURES -ne 0 ]; then echo "error: test suite returned failure(s)" exit 1 fi echo "test suite completed"
Created attachment 510169 [details] adds a check section to run the nspr tests
Comment on attachment 510169 [details] adds a check section to run the nspr tests I think you don't need TEST_PASSED, you could remove that line. r=kaie
nspr-4.8.8-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nspr-4.8.8-4.fc15
Package nspr-4.8.8-4.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nspr-4.8.8-4.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/nspr-4.8.8-4.fc15 then log in and leave karma (feedback).