Bug 717246 - thunderbird-lightning : does not adhere to Static Library Packaging Guidelines
Summary: thunderbird-lightning : does not adhere to Static Library Packaging Guidelines
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: thunderbird-lightning
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-28 12:49 UTC by Michael Schwendt
Modified: 2011-08-09 19:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-09 19:37:22 UTC
Type: ---


Attachments (Terms of Use)

Description Michael Schwendt 2011-06-28 12:49:03 UTC
thunderbird-lightning-1.0-0.41.b3pre.fc15.src
is missing
BuildRequires: nss-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link against it provided that you BuildRequire the *-static subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.

Comment 1 Orion Poplawski 2011-06-28 18:19:07 UTC
I note that there is no nss-static package.  Perhaps a bug could be filed against nss first and made to block this?

Comment 2 Michael Schwendt 2011-06-28 19:59:30 UTC
nss-static is a virtual package provided by nss-devel since yesterday.

Btw, this ticket has been filed automatically:
http://mschwendt.fedorapeople.org/staticbugstat.html

Comment 3 Orion Poplawski 2011-06-28 20:28:15 UTC
I get:

DEBUG util.py:250:  Error: No Package found for nss-static >= 3.12.8

with:

BuildRequires:  nss-static >= %{nss_version}

I'll change to:

BuildRequires:  nss-devel >= %{nss_version
BuildRequires:  nss-static

Comment 4 Michael Schwendt 2011-06-28 20:57:59 UTC
From you job's root.log:

DEBUG util.py:250:   nss                       x86_64    3.12.9-11.fc16              build    748 k

Look at the version! It's ancient: 2011-02-16

There have been many newer builds of nss in Rawhide, including new versions:
http://koji.fedoraproject.org/koji/packageinfo?packageID=248

$ koji latest-pkg dist-f16 nss
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
nss-3.12.10-5.fc16                        dist-f16              mschwendt

Comment 5 Jan Horak 2011-07-14 13:49:54 UTC
Hm. This seems to be wrong to me. According to http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2
we shouldn't link against static libraries and we really don't need to do it. 

Or do I miss something here?

Comment 6 Michael Schwendt 2011-07-14 14:03:50 UTC
See comment 2.
nss-devel (with its virtual nss-static name) is a static-only library package. There are no shared builds of the libs it includes:
http://koji.fedoraproject.org/koji/rpminfo?rpmID=2595533


Note You need to log in before you can comment on or make changes to this bug.