Bug 717247 - xulrunner : does not adhere to Static Library Packaging Guidelines
Summary: xulrunner : does not adhere to Static Library Packaging Guidelines
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: thunderbird
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Gecko Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-28 12:49 UTC by Michael Schwendt
Modified: 2018-04-11 10:18 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-07 07:11:13 UTC
Type: ---


Attachments (Terms of Use)

Description Michael Schwendt 2011-06-28 12:49:06 UTC
xulrunner-5.0-3.fc16.src
is missing
BuildRequires: nss-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link against it provided that you BuildRequire the *-static subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.

Comment 1 Matěj Cepl 2011-09-04 00:58:30 UTC
It would be nice if you could tell us which files triggered your script to file this bug for this component. Could you indicate the problematic files for us, please?

Thank you

Comment 2 Michael Schwendt 2011-09-04 11:10:51 UTC
According to the koji build logs which are evaluated, 

  -lcrmf

which is a static-only library.

Comment 3 Martin Stransky 2012-05-04 10:10:39 UTC
Yeah, but this lib comes from nss, it's not a problem with xulrunner.

Comment 4 Martin Stransky 2012-05-04 10:10:54 UTC
*** Bug 717245 has been marked as a duplicate of this bug. ***

Comment 5 Martin Stransky 2012-05-04 10:11:01 UTC
*** Bug 717242 has been marked as a duplicate of this bug. ***

Comment 6 Michael Schwendt 2012-05-04 10:25:08 UTC
xulrunner-5.0-3.fc16.src
is missing
BuildRequires: nss-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link
against it provided that you BuildRequire the *-static subpackage. Packagers in
such a situation should be aware that if a shared library becomes available,
that you should adjust your package to use the shared library.

Comment 7 Michael Schwendt 2012-05-04 10:26:35 UTC
That means, if xulrunner wants to use the static library for linking, it must BuildRequires the -static package.

Comment 8 Martin Stransky 2012-05-04 11:47:29 UTC
But nss does not provide the nss-static subpackage for that, crmf is a part of nss-devel. What can we do in thunderbird with that??

Comment 9 Michael Schwendt 2012-05-04 11:59:59 UTC
nss-static is a virtual package provided by nss-devel (otherwise the script that checks for these errors would not suggest it as a BR), and that's valid according to the guidelines, because nss-devel includes no shared libs.

Comment 10 Martin Stransky 2012-05-04 12:18:44 UTC
Ahh, I see, Thanks for the explanation.

Comment 11 Takanori MATSUURA 2012-05-06 13:06:26 UTC
BTW, is it an upstream bug or policy that CRMF library is provided only as a static library?

https://bugzilla.mozilla.org/show_bug.cgi?id=294542
(Bob Relyea is in Cc in this bug).

Comment 12 Martin Stransky 2012-05-07 07:11:13 UTC
Fixed in rawhide.


Note You need to log in before you can comment on or make changes to this bug.