Created attachment 510344 [details]
Set retval -1 and correct errno on connect failure

Description of problem:
vsftpd does not handle connection failures using the PORT command when a client tries to upload a file to it, but has ftp-data port blocked due to some reason.

Version-Release number of selected component (if applicable):
vsftpd-2.2.2-6.el6_0.1

How reproducible:
Always

Steps to Reproduce:
1. At client:

iptables -A INPUT -p tcp --sport ftp-data -j REJECT --reject-with icmp-net-unreachable

2. Connect to the ftp server
3. Upload file
  
Actual results:

Transfer hangs at:

local: ftptest remote: ftptest
200 PORT command successful. Consider using PASV.
150 Ok to send data.


Expected results:

The client should get an error:

local: ftptest remote: ftptest
200 PORT command successful. Consider using PASV.
425 Failed to establish connection.

Additional info:

Attached patch by Takayuki Nagata <tnagata> fixes this.