Bug 717780 - Failed user login count broken
Summary: Failed user login count broken
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 0.3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
Assignee: Jiri Tomasek
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-29 20:25 UTC by Dave Johnson
Modified: 2012-01-26 12:20 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Dave Johnson 2011-06-29 20:25:20 UTC 
Description of problem:

Under each user account is some login statistics like counts for successful and failed logins, last login IP, login time, etc.  When a failed login occurs, the failed login count is not incremented.  When a successful login occurs, both the successful count and failed count increment.

views/users/_properties.haml has copy/paste error, see below...

    %tr
      %td
        %label Login Count
      %td
        = @user.login_count
    %tr
      %td
        %label Failed Login Count
      %td
        = @user.login_count
Comment 1 Dave Johnson 2011-06-29 20:37:10 UTC 
For grins, I updated the haml file and restarted aeolus-conductor service.

The value in the web UI now shows 0 but does not increment when a failed login occurs so it seems failed login count is completely broken.

Also, it might be interesting to show the Last Failed Login IP.  Not sure if that is possible but figured it was worth mentioning.
Comment 2 Dave Johnson 2011-06-29 21:07:32 UTC 
Almost forgot...

[root@dell-pe1950-02 controllers]# rpm -qa | grep aeolus
aeolus-conductor-0.3.0-0.el6.20110628135944git2a88782.noarch
aeolus-conductor-daemons-0.3.0-0.el6.20110628135944git2a88782.noarch
rubygem-aeolus-cli-0.0.1-1.el6.20110628165632git0dfe3ff.noarch
aeolus-configure-2.0.1-0.el6.20110628141215gitb8aaf85.noarch
aeolus-conductor-doc-0.3.0-0.el6.20110628135944git2a88782.noarch
aeolus-all-0.3.0-0.el6.20110628135944git2a88782.noarch
[root@dell-pe1950-02 controllers]#
Comment 3 Jiri Tomasek 2011-07-08 12:45:00 UTC 
fixed in commit ded7cffd3b44ad8de39b87204762a76cef55073e

failed_login_count gets zeroed after
successfull login which is normal authlogic behavior, so to check failed
login count its nessesary to fail login with some testuser and then
login as admin and see the testuser's failed login count. A test for this is
in commit aadc76ca152ff344619f178864d46c7573116c21
Comment 4 Aziza Karol 2011-09-22 07:36:06 UTC 
Failed login count successfully gets incremented.

verified by failing login for some test user and then as admin verified the failed login count.

verified on:
[root@dell-pesc440-01 nodes]# rpm  -qa  | grep aeolus
aeolus-conductor-doc-0.4.0-0.20110921152740gitac47a38.fc15.noarch
aeolus-conductor-daemons-0.4.0-0.20110921152740gitac47a38.fc15.noarch
rubygem-aeolus-image-0.1.0-3.20110919115936gitd1d24b4.fc15.noarch
aeolus-configure-2.0.2-4.20110921102958gitcaa9608.fc15.noarch
aeolus-conductor-0.4.0-0.20110921152740gitac47a38.fc15.noarch
aeolus-all-0.4.0-0.20110921152740gitac47a38.fc15.noarch

This bug can be marked as verified.
Comment 6 wes hayutin 2011-12-08 13:53:22 UTC 
perm close
Comment 7 wes hayutin 2011-12-08 13:55:58 UTC 
closing out old bugs
Note You need to log in before you can comment on or make changes to this bug.