Hide Forgot
Spec URL: http://people.redhat.com/vondruch/rubygem-hike.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-hike-1.1.0-1.fc16.src.rpm Description: A Ruby library for finding files in a set of paths. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3171697
I'll take this for a review.
- Please update to the latest version of gem (currently 1.2.1). - The specfile you provided differs from the specfile in SRPM (just the two comments in %check, but please fix this). - License is MIT, not GPLv2+ or Ruby. - Please consider updating to the new standard of Rubygems packaging for Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not the old one - use f17-ruby target in Koji). - Otherwise the package looks good, but I'd like to see it once more after it gets updated to the latest version, then I'll gladly approve it. [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby
(In reply to comment #2) > - Please update to the latest version of gem (currently 1.2.1). Done > - The specfile you provided differs from the specfile in SRPM (just the two > comments in %check, but please fix this). Done > - License is MIT, not GPLv2+ or Ruby. Done > - Please consider updating to the new standard of Rubygems packaging for > Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not > the old one - use f17-ruby target in Koji). Done > - Otherwise the package looks good, but I'd like to see it once more after it > gets updated to the latest version, then I'll gladly approve it. > > [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby Spec URL: http://people.redhat.com/vondruch/rubygem-hike.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-hike-1.2.1-1.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745471
The package looks good now => APPROVED.
Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-hike Short Description: Find files in a set of paths Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).