Bug 718176 - Possible problems found by static analysis of code
Summary: Possible problems found by static analysis of code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: portreserve
Version: 6.1
Hardware: All
OS: All
low
low
Target Milestone: rc
: ---
Assignee: Tim Waugh
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On: 704567
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-01 10:03 UTC by Tim Waugh
Modified: 2012-04-03 15:20 UTC (History)
3 users (show)

Fixed In Version: portreserve-0.0.4-7.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 704567
Environment:
Last Closed: 2012-04-03 15:20:09 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0447 0 normal SHIPPED_LIVE portreserve bug fix update 2012-04-03 19:16:29 UTC

Description Tim Waugh 2011-07-01 10:03:33 UTC
+++ This bug was initially created as a clone of Bug #704567 +++

Description of problem:
Static analysis of the code with/without applied patches discovered
some possible problems in the code.


Version-Release number of selected component (if applicable):
portreserve-0.0.4-8.fc15

--- Additional comment from jpopelka on 2011-05-13 11:46:22 EDT ---

Created attachment 498794 [details]
small memory leak

Error: RESOURCE_LEAK:
portreserve-0.0.4/src/portreserve.c:244: alloc_fn: Calling allocation function "malloc".
portreserve-0.0.4/src/portreserve.c:244: var_assign: Assigning: "cfgfile" =  storage returned from "malloc(strlen(dir) + 255UL + 1UL)".
portreserve-0.0.4/src/portreserve.c:245: var_assign: Assigning: "cfgf" = "cfgfile".
portreserve-0.0.4/src/portreserve.c:251: noescape: Variable "cfgfile" is not freed or pointed-to in function "strcpy".
portreserve-0.0.4/src/portreserve.c:254: leaked_storage: Variable "cfgf" going out of scope leaks the storage it points to.
portreserve-0.0.4/src/portreserve.c:254: leaked_storage: Variable "cfgfile" going out of scope leaks the storage it points to.
portreserve-0.0.4/src/portreserve.c:260: noescape: Variable "cfgf" is not freed or pointed-to in function "strcpy".
portreserve-0.0.4/src/portreserve.c:261: noescape: Variable "cfgfile" is not freed or pointed-to in function "reserve".
portreserve-0.0.4/src/portreserve.c:120:22: noescape: "reserve" does not free or save its pointer parameter "file".
portreserve-0.0.4/src/portreserve.c:314: leaked_storage: Variable "cfgf" going out of scope leaks the storage it points to.
portreserve-0.0.4/src/portreserve.c:314: leaked_storage: Variable "cfgfile" going out of scope leaks the storage it points to.

--- Additional comment from twaugh on 2011-05-20 11:00:27 EDT ---

Thanks, applied upstream.

Comment 1 RHEL Program Management 2011-07-06 00:09:32 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 6 RHEL Program Management 2011-08-19 18:08:45 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 10 errata-xmlrpc 2012-04-03 15:20:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0447.html


Note You need to log in before you can comment on or make changes to this bug.