Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-1.fc15.src.rpm Description: Temperature.app is a Window Maker applet which fetches local temperature information every 15 minutes from http://weather.noaa.gov and displays it (in Celsius or Fahrenheit). Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3177486
I've just written a manpage to make rpmlint happy and added it to the package: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-2.fc15.src.rpm
The "Group" tag was missing. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-3.fc15.src.rpm
I've completed and tweaked the manpage a bit: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-4.fc15.src.rpm
The packaging looks quite good and the application seems to work. Anyway: - dockapps.org seems dead unfortunately; is there an alternate place where the WM applet are now available? - in %install, you don't have to refer to %{_builddir} to manually install files: install -p -m 755 %{name} %{buildroot}%{_bindir} You can even discard all the mkdir commands, since install can create the destination directories on the fly: %install install -D -p -m 755 %{name} %{buildroot}%{_bindir}/%{name} install -D -p -m 755 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1.gz - about the man page: where does it come from? If you didn't write it, you should specify its source.
Here's the new spec: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec But there remains the problem with the dead source location. The dockapps.org registration is expired, and the domain has been moved to a domain parking system, that's why I don't expect to get it back in the nearest future. In other cases, I've used the source pool at the Debian servers, but there's no such package. Well, there's another pool for unmaintained dockapps at http://repo.or.cz/w/dockapps.git, perhaps I should use it. It also includes some bugfixes, seems to be the best way for me.
(In reply to comment #5) > Well, there's another pool for unmaintained dockapps at > http://repo.or.cz/w/dockapps.git, perhaps I should use it. It also includes > some bugfixes, seems to be the best way for me. That seems good to me too. That's a guarantee to have maintained sources.
The download URL is up again! It's now a subdomain of windowmaker.org. New spec: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3584320
(In reply to comment #7) > The download URL is up again! It's now a subdomain of windowmaker.org. Great news :) About the man page: you should provide it uncompressed: when building a RPM, man pages are automatically compressed.
OK, the manpage is now uncompressed. Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-7.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3608803
Here is the review: +:ok, =:needs attention, -:needs fixing MUST Items: [-] MUST: rpmlint must be run on every package. Temperature.app.src: I: enchant-dictionary-not-found de Temperature.app.src: W: invalid-url URL: http://www.dockapps.windowmaker.org/file.php/id/86 <urlopen error [Errno -2] Name or service not known> Temperature.app.src: W: invalid-url Source0: http://www.dockapps.windowmaker.org/download.php/id/816/Temperature.app-1.5.tar.gz <urlopen error [Errno -2] Name or service not known> Temperature.app.x86_64: W: invalid-url URL: http://www.dockapps.windowmaker.org/file.php/id/86 <urlopen error [Errno -2] Name or service not known> Temperature.app.x86_64: W: spurious-executable-perm /usr/share/man/man1/Temperature.app.1.gz Temperature.app.x86_64: E: incorrect-fsf-address /usr/share/doc/Temperature.app-1.5/COPYING Temperature.app-debuginfo.x86_64: W: invalid-url URL: http://www.dockapps.windowmaker.org/file.php/id/86 <urlopen error [Errno -2] Name or service not known> Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/Temperature.app-1.5/Xpm.cc Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/Temperature.app-1.5/Xpm.h Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/Temperature.app-1.5/Temperature.h Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/Temperature.app-1.5/Temperature.cc Temperature.app-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/Temperature.app-1.5/Main.cc 3 packages and 0 specfiles checked; 6 errors, 5 warnings. >>The warnings can be safely ignored, except the one about the permissions on Temperature.app; fix it as below in %install: install -D -p -m 644 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1 >>The source URL must be fixed too : it has no « www » in fact. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. >>MD5 sum=e8d294085ebbe062f0d7b02dfb1d1071 OK [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. [+] MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [+] MUST: Static libraries must be in a -static package. [+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. Once the source URL fixed and the permissions on the man page fixed, I will approve your package.
The issues are fixed now. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3628228 Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/Temperature.app.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/Temperature.app-1.5-8.fc16.src.rpm
APPROVED
Many thanks for your approval!
New Package SCM Request ======================= Package Name: Temperature.app Short Description: Window Maker applet which fetches local temperature information Owners: mariobl Branches: f16
Git done (by process-git-requests).
Temperature.app-1.5-8.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/Temperature.app-1.5-8.fc16
Temperature.app-1.5-8.fc16 has been pushed to the Fedora 16 testing repository.
Temperature.app-1.5-8.fc16 has been pushed to the Fedora 16 stable repository.