Bug 718726 - login: An error occurs when authentication fails
Summary: login: An error occurs when authentication fails
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-webadmin
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: m2
: 3.1
Assignee: Vojtech Szocs
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: nogah-admin-ms1
TreeView+ depends on / blocked
 
Reported: 2011-07-04 12:41 UTC by Asaf Shakarchi
Modified: 2012-08-09 07:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-09 07:59:05 UTC
oVirt Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Asaf Shakarchi 2011-07-04 12:41:16 UTC
Comment 1 Asaf Shakarchi 2011-07-04 18:24:26 UTC 
If this error is unexpected, it must be solved, right now it wont be showed due to this fix:
LoginSectionPresenter onReveal() disables FrontendEventsHandlerImpl-related error popups, onHide() enables them again

NOTE: Commit: 57a1daa42272cd833015d8c977bf2b9234600333 hiding errors when login popup is revealed,
Comment 2 Vojtech Szocs 2011-07-29 11:20:57 UTC 
There are multiple calls within UiCommon to Frontend.RunQuery() early on, even when the user is not logged in yet.

There are two UiCommon integration classes within WebAdmin, which use ErrorPopupManager to show an error popup upon some error event:
- FrontendEventsHandlerImpl
- FrontendFailureEventListener

Proposed solution: inside LoginSectionPresenter.onReveal(), tell ErrorPopupManager to suppress showing popups [currently this is done only for FrontendEventsHandlerImpl].

In any case, UiCommon developers should state how the application should react in this situation (application is launched and login form is shown, user is not logged in yet).
Comment 3 Itamar Heim 2012-08-09 07:59:05 UTC 
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/
Note You need to log in before you can comment on or make changes to this bug.