Hide Forgot
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-1.fc15.src.rpm Description: A C++ interface around LibRaw library
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-3.fc15.src.rpm %changelog * Sun Jul 10 2011 Rex Dieter <rdieter> 4.6.90-3 - License: GPLv2+ - %%doc: +ChangeLog NEWS - add %%check section * Wed Jul 06 2011 Rex Dieter <rdieter> 4.6.90-2 - fix URL - Conflicts: kdegraphics < 7:4.6.90-10
rpmlint output for libkdcraw-4.6.90-3 rpms: libkdcraw.i686: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw.src: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw.x86_64: E: description-line-too-long C picture files. More information about LibRaw can be found at http://www.libraw.org. libkdcraw-devel.i686: W: no-documentation libkdcraw-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 3 errors, 2 warnings. So description-line-too-long should be fixed. update-desktop-database in %posttrans not needed because no desktop files installed. libkdcraw license is GPLv2+ but it built using libRaw sources which have different licenses. libRaw have license LGPLv2 or CDDL. It uses demosaic-pack-GPL2 and demosaic-pack-GPL3 sources. There is notes about demosaic-packs license in README.demosaic-packs: Unfortunately, some of these methods are distributed under the terms of different versions of GNU General Public License (GPL). So it is not possible to include implementation of these demosaics into the LibRaw distribution because LibRaw is distributed under more liberal licenses (LGPL and CDDL). Of course, it is possible to distribute these demosaic methods in separate packages and use within LibRaw under following conditions: * LibRaw is used under the terms of LGPL license which is GPL-compatible * Resulting product (which uses LibRaw AND LibRaw-demosaic-pack) is licensed under GPL2+ (for GPL2 demosaic-pack) or GPL3+ (if demosaic-pack-GPL3 is used). So I guess that resulting License tag for libkdkraw should be GPLv2+ and GPLv3+? This README also can be added in %doc.
Or maybe should be License: GPLv3+?
A bit of a mess, wrt licening and bundled code, I'll look into using system-libraw.
There is no system-wide shared libRaw library if you mean this package http://koji.fedoraproject.org/koji/packageinfo?packageID=10605 Only static lib available there libraw.a which version older than in libkdcraw tarball. So using libRaw-devel not makes sense because even if libRaw-devel will be updated libkdcraw will use previous version.
Here explanation why libraw included in libkdcraw http://mail.kde.org/pipermail/digikam-devel/2010-March/041682.html > So, due the experimental stage of libraw for the moment, and until the > implementation and the API will be stabilized, i think that including > libraw as well is better.
Ah thanks! ok, I'll rework this assuming bundling then.
It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libkdcraw
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkdcraw-4.6.90-5.fc15.src.rpm %changelog * Mon Jul 11 2011 Rex Dieter <rdieter> 4.6.90-5 - License: GPLv2+ and LGPLv2 and GPLv3+ - Provides: bundled(LibRaw) * Sun Jul 10 2011 Rex Dieter <rdieter> 4.6.90-4 - fix URL - fix scriptlets
rpmlint output for ibkdcraw-4.6.90-5 rpms: libkdcraw.i686: W: spurious-executable-perm /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.i686: E: incorrect-fsf-address /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.src:25: W: unversioned-explicit-provides bundled(LibRaw) libkdcraw.src:27: W: unversioned-explicit-provides bundled(LibRaw-demosaic-pack-GPL2) libkdcraw.src:28: W: unversioned-explicit-provides bundled(LibRaw-demosaic-pack-GPL3) libkdcraw.x86_64: W: spurious-executable-perm /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw.x86_64: E: incorrect-fsf-address /usr/share/doc/libkdcraw-4.6.90/LICENSE.LGPL libkdcraw-devel.i686: W: no-documentation libkdcraw-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 7 warnings.
rpmlint errors not serious and can be fixed later. Package and spec names are fine, description is fine now, license GPLv2+ and LGPLv2 and GPLv3+ is actual license used in libkdcraw and bundled libraw sources, Requires in devel package fine, scriptlets are fine, package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3190903 Package APPROVED
Thanks. What's the purpose of marking fedora_requires_release_note flag? New Package SCM Request ======================= Package Name: libkdcraw Short Description: A C++ interface around LibRaw library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
pkgdb says it already exists.
doh, forgot about that, let's try change request instead then. fyi, this needs also to be marked not deprecated. Package Change Request ====================== Package Name: libkdcraw Short Description: A C++ interface around LibRaw library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
Git done (by process-git-requests).
Did f15 branch, can't do 1 or 3, you'll need to file a rel-eng trac.
imported.