Bug 719325 (libkexiv2) - Review Request: libkexiv2 - An Exiv2 wrapper library
Summary: Review Request: libkexiv2 - An Exiv2 wrapper library
Keywords:
Status: CLOSED RAWHIDE
Alias: libkexiv2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-06 13:51 UTC by Rex Dieter
Modified: 2011-12-08 18:19 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-12 17:08:23 UTC
Type: ---
alekcejk: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 nucleo 2011-07-06 17:14:02 UTC
All files have GPLv2+ license excpept libkexiv2_export.h which is LGPLv2+.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3182914

rpmlint output:

libkexiv2.i686: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.src: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/libkexiv2-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.>
libkexiv2.x86_64: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2-devel.i686: W: no-documentation
libkexiv2-devel.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 9 warnings.

Comment 2 nucleo 2011-07-06 17:30:45 UTC
No icons and desktop files installed in this package so gtk-update-icon-cache and update-desktop-database not needed.

NEWS and ChangeLog files can be added in %doc.

Comment 3 nucleo 2011-07-09 14:54:59 UTC
rmplint output on all libkexiv2-4.6.90-2 rpms:

libkexiv2.i686: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.i686: W: incoherent-version-in-changelog 4.6.90-1 ['4.6.90-2.fc15', '4.6.90-2']
libkexiv2.src: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.x86_64: W: summary-not-capitalized C an Exiv2 wrapper library
libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.x86_64: W: incoherent-version-in-changelog 4.6.90-1 ['4.6.90-2.fc15', '4.6.90-2']
libkexiv2-devel.i686: W: no-documentation
libkexiv2-devel.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 10 warnings.

Comment 4 nucleo 2011-07-09 14:57:28 UTC
So there are still issues with summary-not-capitalized and incoherent-version-in-changelog from rpmlint that should be fixed.
Also license and scriptlets should be fixed then package can be approved.

Comment 5 nucleo 2011-07-09 23:40:46 UTC
ChangeLog is outdated so it is enough to add NEWS in %doc.

Comment 6 Rex Dieter 2011-07-10 14:44:15 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2-4.6.90-3.fc15.src.rpm

%changelog
* Sun Jul 10 2011 Rex Dieter <rdieter> 4.6.90-3
- License: GPLv2+
- fix Summary
- %%doc: +ChangeLog NEWS
- drop uneeded scriptlets
- add %%check section

* Wed Jul 06 2011 Rex Dieter <rdieter> 4.6.90-2
- fix URL
- Conflicts: kdegraphics < 7:4.6.90-10

Comment 7 nucleo 2011-07-10 17:42:29 UTC
Package builds in mock:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3189685

rpmlint output for libkexiv2-4.6.90-3 rpms:

libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.i686: W: file-not-utf8 /usr/share/doc/libkexiv2-4.6.90/ChangeLog
libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
libkexiv2.x86_64: W: file-not-utf8 /usr/share/doc/libkexiv2-4.6.90/ChangeLog
libkexiv2-devel.i686: W: no-documentation
libkexiv2-devel.x86_64: W: no-documentation

I think that file-not-utf8 is not blocker (only 2 not utf-8 bytes appeared there accidentally).

Package and spec names are fine,
license GPLv2+ is actual license used in libkexiv2 sources,
scriptlets are fine (/sbin/ldconfig in %post and %postun)
Package builds in mock:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3189685

Package APPROVED

Comment 8 Rex Dieter 2011-07-10 20:32:58 UTC
Thanks.

New Package SCM Request
=======================
Package Name: libkexiv2
Short Description: An Exiv2 wrapper library
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15

Comment 9 nucleo 2011-07-11 01:21:13 UTC
It is will be better to change URL to
https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2
Sorry that I not noticed this before.

Comment 10 Gwyn Ciesla 2011-07-11 15:16:20 UTC
pkgdb says this already exists.

Comment 11 Rex Dieter 2011-07-11 16:55:46 UTC
doh, forgot about that, let's try change request instead then.  fyi, this needs also to be marked not deprecated.


Package Change Request
======================
Package Name: libkexiv2
Short Description: An Exiv2 wrapper library
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15

Comment 12 Gwyn Ciesla 2011-07-11 17:15:20 UTC
Git done (by process-git-requests).

Comment 13 Gwyn Ciesla 2011-07-11 17:17:33 UTC
Did f15 branch, can't do 1 and 3, you'll need to file a rel-eng trac.

Comment 14 Rex Dieter 2011-07-12 17:08:23 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.