Bug 719327 (libksane) - Review Request: libksane - SANE Library interface for KDE
Summary: Review Request: libksane - SANE Library interface for KDE
Keywords:
Status: CLOSED RAWHIDE
Alias: libksane
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: nucleo
QA Contact: nucleo
URL:
Whiteboard:
: 719326 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-06 13:56 UTC by Rex Dieter
Modified: 2011-12-08 18:20 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-07-12 17:08:41 UTC
Type: ---
Embargoed:
alekcejk: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2011-07-06 13:56:30 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-1.fc15.src.rpm
Description: SANE Library interface for KDE

Comment 1 Rex Dieter 2011-07-06 13:58:00 UTC
*** Bug 719326 has been marked as a duplicate of this bug. ***

Comment 2 nucleo 2011-07-10 19:54:43 UTC
rpmlint output for libksane-4.6.90-2 rpms built from http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-2.fc15.src.rpm

libksane-devel.i686: W: no-documentation
libksane-devel.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 3 nucleo 2011-07-10 20:03:24 UTC
Package and spec names are fine, 
license LGPLv2+ is actual license used in libksane sources (twain.h is not used when system libsane found), 
Requires in devel package fine,
scriptlets are fine.
Package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3189868

The only thing should be fixed is replace COPYING with COPYING.LIB in %doc because this license used here.

Comment 4 Rex Dieter 2011-07-10 20:30:54 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdegraphics/libksane-4.6.90-3.fc15.src.rpm

%changelog
* Sun Jul 10 2011 Rex Dieter <rdieter> 4.6.90-3
- %%doc COPYING.LIB
- add basic %%check section

Comment 5 nucleo 2011-07-10 20:53:36 UTC
libksane-4.6.90-3 also builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=3189893
rpmlint output fine.
So all issues fixed now and 

package is APPROVED.

Comment 6 Rex Dieter 2011-07-10 22:51:06 UTC
Thanks.

New Package SCM Request
=======================
Package Name: libksane
Short Description: SANE Library interface for KDE
Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Branches: f15

Comment 7 nucleo 2011-07-11 01:19:35 UTC
It is will be better to change URL to
https://projects.kde.org/projects/kde/kdegraphics/libs/libksane
Sorry that I not noticed this before.

Comment 8 Gwyn Ciesla 2011-07-11 15:14:38 UTC
Git done (by process-git-requests).

nucleo, please take ownership of review tickets you're working on. Thank
you!

Comment 9 Rex Dieter 2011-07-12 17:08:41 UTC
imported.


Note You need to log in before you can comment on or make changes to this bug.