Bug 722532 - Need to harden listing file parsing
Summary: Need to harden listing file parsing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Update Infrastructure for Cloud Providers
Classification: Red Hat
Component: Tools
Version: 2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Jay Dobies
QA Contact: wes hayutin
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-15 15:24 UTC by Jay Dobies
Modified: 2012-05-31 12:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-31 12:52:23 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Jay Dobies 2011-07-15 15:24:57 UTC 
CDN is inconsistent with the amount of blank lines and space in listings files, so we need to harden the parsing to strip them out. In RHUI 2.0.38 and lower, it can be seen on a staging certificate when importing RHEL 6. It creates repos including:


  Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server-x86_64)
  Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server-i386)
  Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server)


The last isn't valid; only the ones with architectures are.
Comment 1 Jay Dobies 2011-07-15 15:25:58 UTC 
commit c45abba0c892efb547e6f917a84ebb0df0e85177
Author: Jay Dobies <jason.dobies>
Date:   Fri Jul 15 11:25:19 2011 -0400

    722532 - Stronger parsing out of blank entries in listings

rhui-2.0/tools/src/rhui/tools/cdn_api.py
Comment 2 Jay Dobies 2011-07-15 15:27:33 UTC 
Fixed in 2.0.40.
Comment 3 Sachin Ghai 2011-07-21 12:01:25 UTC 
I verified in build 2.0.40.
When I choose  "Red Hat Enterprise Linux 6 Server from RHUI (RPMs)" product, its creates following repos:

The following products will be deployed:
  Red Hat Enterprise Linux 6 Server from RHUI (RPMs)
Proceed? (y/n) y


Importing Red Hat Enterprise Linux 6 Server from RHUI (RPMs)...
  Importing product repository Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6.1-i386)...
  Importing product repository Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6.1-x86_64)...
  Importing product repository Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server-i386)...
  Importing product repository Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6.0-x86_64)...
  Importing product repository Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6.0-i386)...

Content will not be downloaded to the newly imported repositories
until the next sync is run.


Please notice that its importing 5 different repos of rhel6. And 6Server-x86_64 was already imported. So not listed here.
- (6.1-i386)
- (6.1-x86_64)
- (6Server-i386)
- (6.0-x86_64)
- (6.0-i386)


6.0 and 6.1 repos seems to be rhel6 base and rhel6 with update1 respectively. But not sure about third 6Server repo.

Jay, please confirm If this entry looks okay, I'll move this to verified.
Comment 4 Jay Dobies 2011-07-25 12:22:43 UTC 
Sachin - Yes, this looks ok. I had to ask about that myself since I was surprised to see three entries (6Server, 6.0, and 6.1), but that's expected based on how CDN organizes things.
Comment 5 Sachin Ghai 2011-07-25 12:53:11 UTC 
Based on comments 3 and comments 4, moving this to verified. Thanks.
Comment 6 wes hayutin 2011-08-01 21:38:44 UTC 
moving to release pending
Comment 7 wes hayutin 2012-05-31 12:52:23 UTC 
closing out, product released
Note You need to log in before you can comment on or make changes to this bug.