Hide Forgot
For now the bot will restore the needinfo on reviewer if the person who last updated the cert is non-redhat people,i think it's not accurate,sometime TAM will help to upload some packages on behalf of vendor or place some comments for reviewer for further action,but if they forget to set the needinfo on reviewer,bot will not help to do so since TAM is not non-redhat people. -wjw
People are in accurate yes, however we should not have every non-reviewer action require a reviewer response. If a package is uploaded the package review flag should be set such that the package is reviewed. This is recorded separately from the needinfo which is only about dialog. eg. that a question was asked of the review team.
(In reply to comment #1) > People are in accurate yes, however we should not have every non-reviewer > action require a reviewer response. If a package is uploaded the package > review flag should be set such that the package is reviewed. This is recorded > separately from the needinfo which is only about dialog. eg. that a question > was asked of the review team. the certs with pack_review flag will not appear in the pack_review queue unless the needinfo is set on reviewer meantime,i confirmed this with Weishen. Please see this cert https://hardware.redhat.com/show.cgi?id=722316#c8 The package was uploaded on 2011-07-15 14:03 but it's not included in next work queue or pack_review queue,hence we didn't process it in time. Thanks -wjw
I have applied a patch for this, please check it.
Then hwcertbot is broken and it should be fixed. Needinfo is not a prerequisite to package review. Which issue was addressed by the patch?
this is caused by the missing rule for this situation in hwcertbot code, in the patch I added a new rule as No.5005 in the flagChecker.pl, which deals with this the person who last updated cert is a redhat people but not reviewer( tam, etc.),and there is already a needinfo pending on vendor, and there is no needinfo pending on reviewer, and the cert is not closed, in this condition, bot will add needinfo to reviewer. As in the design, if the cert is pending on vendor's response, it does not show up in next work queue.
Ok, so the root issue is waiting for a vendor response may impede reviewer progress or it may not and the bot can't tell the difference so it defers to a review to take a look?
correct, tam may upload results for vendors and forget to set needinfo on reviewer
2 more rules have been added to address : 5006 last update person is vendor, and needinfo on tam and no needinfo on reviewer 5007 last update person is redhat people, and no needinfo on reviewer, needinfo on tam thus all cases of the bug should be covered. This has been implemented in 2.1-12, and working well now, I am closing this bug.