Bug 723197 - Review Request: ooo2gd - LibreOffice extension for working with Google Docs
Summary: Review Request: ooo2gd - LibreOffice extension for working with Google Docs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-19 11:09 UTC by David Tardon
Modified: 2011-07-27 04:59 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-26 05:16:34 UTC
Type: ---
caolanm: fedora-review+


Attachments (Terms of Use)

Description David Tardon 2011-07-19 11:09:45 UTC
Spec URL: http://dtardon.fedorapeople.org/ooo2gd.spec
SRPM URL: http://dtardon.fedorapeople.org/ooo2gd-3.0.0-1.fc16.src.rpm
Description: 
OpenOffice.org2GoogleDocs (OOo2GD) is a plugin to
OpenOffice.org/StarOffice (should work also with other Offices derived
from OpenOffice.org) which will let you export and import your
documents, spreadsheets and presentations to and from Google Docs, Zoho.
It will let you also export your files to WebDAV servers and
"synchronize" your documents, spreadsheets and presentations with Google
Docs.

So, you can:
* Export documents, spreadsheets and presentations to Google Docs, Zoho
  and WebDAV
* Import documents, spreadsheets and presentations from Google Docs and
  Zoho
* Synchronize your documents with Google Docs

Comment 1 David Tardon 2011-07-19 11:20:42 UTC
rpmlint run, with inline comments:

rpmlint SPECS/ooo2gd.spec SRPMS/ooo2gd-3.0.0-1.fc16.src.rpm RPMS/x86_64/ooo2gd-3.0.0-1.fc16.x86_64.rpm 
SPECS/ooo2gd.spec: W: invalid-url Source1: nbproject.tar.bz2
SPECS/ooo2gd.spec: W: invalid-url Source0: ooo2gd-3.0.0.tar.bz2
ooo2gd.src: W: invalid-url Source1: nbproject.tar.bz2
ooo2gd.src: W: invalid-url Source0: ooo2gd-3.0.0.tar.bz2

Upstream does not do source releases. And it does not include nbproject directory in the repository.

ooo2gd.x86_64: E: no-binary
ooo2gd.x86_64: W: only-non-binary-in-usr-lib

LibreOffice places all bundled extensions into one directory, therefore this package must be arch-specific even if it is technically noarch. IMHO it should not be very hard to extend LibreOffice to allow multiple directories for one type of "deployment context" (bundled, shared, user), but that is for the future.

ooo2gd.x86_64: W: no-documentation

So what?

ooo2gd.x86_64: W: class-path-in-manifest /usr/lib64/libreoffice/share/extensions/ooo2gd/GDocs.jar

That is the idea. It does not work otherwise.

2 packages and 1 specfiles checked; 1 errors, 7 warnings.

Comment 2 Caolan McNamara 2011-07-21 08:45:05 UTC
# MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review

rpmlint /home/caolan/rpmbuild/RPMS/x86_64/ooo2gd-3.0.0-1.fc15.x86_64.rpm
ooo2gd.x86_64: E: no-binary
ooo2gd.x86_64: W: only-non-binary-in-usr-lib
  + has a .jar, has to be under libreoffice hierarchy, libo-side lossage
ooo2gd.x86_64: W: no-documentation
  + none included
ooo2gd.x86_64: W: class-path-in-manifest /usr/lib64/libreoffice/share/extensions/ooo2gd/GDocs.jar
  + necessary


# MUST: The package must be named according to the Package Naming Guidelines.

ok  

# MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.

ok

# MUST: The package must meet the Packaging Guidelines

ok

# MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines

ok

# MUST: The License field in the package spec file must match the actual license.

ok

# MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.

ok, no file included, should drop a line to author, maybe with patch, to bundle the license into their source tree and/or insert it into .java headers

# MUST: The spec file must be written in American English.

ok

# MUST: The spec file for the package MUST be legible.

ok

# MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.

ok

# MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.

ok

# MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.

ok

# MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.

ok

# MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

ok

# MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.

ok

# MUST: Packages must NOT bundle copies of system libraries.

ok

# MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.

ok

# MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.

ok


# MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)

ok

# MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.

ok

# MUST: Each package must consistently use macros.

ok

# MUST: The package must contain code, or permissable content.

ok

# MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).

ok

# MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.

ok

# MUST: Header files must be in a -devel package.

ok

# MUST: Static libraries must be in a -static package.

ok

# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.

ok

# MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}


ok

# MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.

ok

# MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.

ok

# MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.

ok

# MUST: All filenames in rpm packages must be valid UTF-8.

ok

Comment 3 David Tardon 2011-07-21 08:58:05 UTC
New Package SCM Request
=======================
Package Name: ooo2gd
Short Description: Extension for OpenOffice.org to export documents to Google Docs
Owners: dtardon
Branches: rawhide
InitialCC: caolanm

Comment 4 Gwyn Ciesla 2011-07-21 12:09:10 UTC
Git done (by process-git-requests).

Don't request rawhide, rawhide==devel and is automatic.  Thanks!

Comment 5 Gwyn Ciesla 2011-07-26 12:05:03 UTC
Nothing new here, why was the SCM flag set?

Comment 6 David Tardon 2011-07-27 04:59:36 UTC
The bug history shows that I set (or, better to say, reset) it when closing the bug, but I didn't touch the flags at all. It seems firefox 5 is playing games with me, randomly changing controls. Similar thing happened earlier when I changed the component to 0xFFFF without knowing it...


Note You need to log in before you can comment on or make changes to this bug.