Bug 723229 - Defects revealed by Coverity scan
Summary: Defects revealed by Coverity scan
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: xorg-x11-drv-qxl
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Søren Sandmann Pedersen
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-19 13:22 UTC by Michal Luscon
Modified: 2014-06-18 09:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-10 15:15:57 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Michal Luscon 2011-07-19 13:22:09 UTC
Description of problem:

xf86-video-qxl-0.0.12/src/qxl_surface.c:392 - Function malloc without NULL check.

xf86-video-qxl-0.0.12/src/qxl_surface.c:1154 - Function malloc without NULL check.

xf86-video-qxl-0.0.12/src/qxl_driver.c:377 - Suspicious implicit sign extension: "qxl->main_mem_slot" with type "unsigned char" (8 bits, unsigned) is promoted in "qxl->main_mem_slot << qxl->slot_gen_bits" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned).  If "qxl->main_mem_slot << qxl->slot_gen_bits" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.

xf86-video-qxl-0.0.12/src/qxl_driver.c:397 - Suspicious implicit sign extension: "qxl->vram_mem_slot" with type "unsigned char" (8 bits, unsigned) is promoted in "qxl->vram_mem_slot << qxl->slot_gen_bits" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned).  If "qxl->vram_mem_slot << qxl->slot_gen_bits" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.

Version-Release number of selected component (if applicable):
0.0.12-9

Additional info:

These defects were probably introduced by Red Hat patches.

Comment 1 RHEL Program Management 2011-10-07 16:18:29 UTC
Since RHEL 6.2 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.


Note You need to log in before you can comment on or make changes to this bug.