Bug 723338 - [PATCH] Also run javahl unit tests in %check
Summary: [PATCH] Also run javahl unit tests in %check
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: subversion
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Joe Orton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-19 19:49 UTC by Blair Zajac
Modified: 2011-07-20 17:15 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-20 12:06:33 UTC
Type: ---

Attachments (Terms of Use)
Patch to subversion.spec to run javahl unit tests. (1.12 KB, patch)
2011-07-19 19:54 UTC, Blair Zajac 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Blair Zajac 2011-07-19 19:49:55 UTC 
Description of problem: The javahl bindings are not checked in %check.

Version-Release number of selected component (if applicable): rawhide 1.6.16

Patch attached that runs these tests also.
Comment 1 Blair Zajac 2011-07-19 19:50:17 UTC 
Update subject.
Comment 2 Blair Zajac 2011-07-19 19:54:59 UTC 
Created attachment 513874 [details]
Patch to subversion.spec to run javahl unit tests.
Comment 3 Joe Orton 2011-07-20 09:56:26 UTC 
Thanks!

It fails like this:

+ make check-javahl
/usr/lib/jvm/java/bin/java "-Dtest.rootdir=/builddir/build/BUILD/subversion-1.6.17
...
Time: 0.024
There were 50 errors:
1) testCreate(org.tigris.subversion.javahl.SVNAdminTests)java.lang.UnsatisfiedLinkError: no svnjavahl-1 in java.library.path

I guess we need to set LD_LIBRARY_PATH appropriately to pick up the buildroot's libsvnjavahl-1.so.  I'm having a look...
Comment 4 Joe Orton 2011-07-20 09:56:45 UTC 
Forgot the reference: http://koji.fedoraproject.org/koji/taskinfo?taskID=3213926
Comment 5 Joe Orton 2011-07-20 10:22:06 UTC 
Looks like we weren't passing --enable-javahl (!) and so the Makefile was not set up correctly...
Comment 6 Joe Orton 2011-07-20 12:06:33 UTC 
Works: http://koji.fedoraproject.org/koji/buildinfo?buildID=254238
Comment 7 Blair Zajac 2011-07-20 17:15:55 UTC 
I did a git clone the other day and didn't see 1.6.17 in there.

Thanks for rolling it out!

Blair
Note You need to log in before you can comment on or make changes to this bug.