Bug 725168 - Review Request: Xspice - X and Spice server
Summary: Review Request: Xspice - X and Spice server
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-drv-qxl
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-23 15:24 UTC by Alon Levy
Modified: 2014-08-04 22:08 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-13 12:16:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
updated spec (2.29 KB, text/x-rpm-spec)
2011-08-02 12:36 UTC, Marc-Andre Lureau
no flags Details

Description Alon Levy 2011-07-23 15:24:35 UTC
Spec URL: http://people.freedesktop.org/~alon/xspice.spec
SRPM URL: http://people.freedesktop.org/~alon/xspice-0.0.16-1.fc15.src.rpm
Description: xspice is an X and Spice server. It uses the spice protocol to transfer the screen, mouse and keyboard of the user to the X server. Spice provides a more efficient protocol then pure X for networking, and allows disconnects of the viewer application without affecting the X clients.

It is not a separate X server, but reuses the regular Xorg xserver. It is comprised of:

 * launcher script xspice, that execs Xorg after setting up environment variables.
 * spiceqxl_drv.so - xorg module that includes the video, keyboard and mouse drivers, and links with spice-server.
 * spiceqxl.xorg.conf - config file that xspice passes to Xorg via -config, that references those three drivers.

Comment 1 Marc-Andre Lureau 2011-08-02 12:33:01 UTC
* Wrong depedency on spice-sever: replaced with spice-server-devel
*  rpmlint xspice-0.0.16-1.fc15.src.rpm 
  xspice.src: W: summary-not-capitalized C xspice, an X and spice server
  xspice.src: W: name-repeated-in-summary C xspice
- The name 'xspice' doesn't follow convention to prefix with xorg-x11-server- X11 servers: xorg-x11-server-Xspice instead
- updated summary
* rpmlint xorg-x11-server-Xspice-0.0.16-1.fc15.x86_64.rpm
  xorg-x11-server-Xspice.x86_64: W: non-conffile-in-etc /etc/X11/spiceqxl.xorg.conf
  xorg-x11-server-Xspice.x86_64: W: no-manual-page-for-binary xspice
- added %config

package name: modified
spec file name: modified
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
spec readability: ok
upstream sources: ok
buildable: yes
excludearch: FIXME (MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8])
buildrequires: modified
locale handling: ok
ldconfig: ok
system libs: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
header files: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
utf8 filenames: ok

Comment 2 Marc-Andre Lureau 2011-08-02 12:35:53 UTC
elmarco@makai:~$ xspice --port 5900 --disable-ticketing :1.0
missing ca-cert - ./ca-cert.pem does not exist

What am I supposed to do? Anything missing in the package to make it work by default after installation?

Comment 3 Marc-Andre Lureau 2011-08-02 12:36:24 UTC
Created attachment 516316 [details]
updated spec

Comment 4 Marc-Andre Lureau 2011-08-02 12:39:31 UTC
Missing requires: python?

Comment 5 Alon Levy 2011-08-02 21:04:24 UTC
Updated spec, update srpm: New urls (erased the old to avoid confusion):
http://annarchy.freedesktop.org/~alon/Xspice/xorg-x11-server-Xspice.spec
http://annarchy.freedesktop.org/~alon/Xspice/xorg-x11-server-Xspice-0.0.16-1.fc15.src.rpm
(prebuilt binaries for x86_64 are also there)

1. added Require: python >= 2.6
2. added several patches that rename the executable to Xspice and fix the ca-cert issue you noticed.
3. Updated spec to include comment on why it excludes the excluded arches, per the guidelines in [8], since this is a new package the bugs are to be opened only after it is approved. Here is the section from [8]:
Architecture Build Failures

If a Fedora package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number should then be placed in a comment, next to the corresponding ExcludeArch line. New packages will not have bugzilla entries during the review process, so they should put this description in the comment until the package is approved, then file the bugzilla entry, and replace the long explanation with the bug number. The bug should be marked as blocking one (or more) of the following bugs to simplify tracking such issues:

    FE-ExcludeArch-x86
    FE-ExcludeArch-x64
    FE-ExcludeArch-ppc
    FE-ExcludeArch-ppc64
    F-ExcludeArch-arm
    F-ExcludeArch-s390x
    F-ExcludeArch-sparc

Comment 6 Marc-Andre Lureau 2011-08-30 14:39:54 UTC
looks ok to me now, you should try to find an official packager now.

Comment 7 Hans de Goede 2011-09-13 12:16:05 UTC
As discussed on irc, since this is building from the same upstream tarbal as xorg-x11-drv-qxl, it should just be a subpackage of that.

I've just completed a build of xorg-x11-drv-qxl with a xorg-x11-server-Xspice subpackage (F-16 and F-15 to follow soon) -> closing this bug.


Note You need to log in before you can comment on or make changes to this bug.