Spec URL: http://labs.linuxnetz.de/bugzilla/phpMyAdmin3.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/phpMyAdmin3-3.4.3.2-2.src.rpm Description: phpMyAdmin is a tool written in PHP intended to handle the administration of MySQL over the World Wide Web. Most frequently used operations are supported by the user interface (managing databases, tables, fields, relations, indexes, users, permissions), while you still have the ability to directly execute any SQL statement. Features include an intuitive web interface, support for most MySQL features (browse and drop databases, tables, views, fields and indexes, create, copy, drop, rename and alter databases, tables, fields and indexes, maintenance server, databases and tables, with proposals on server configuration, execute, edit and bookmark any SQL-statement, even batch-queries, manage MySQL users and privileges, manage stored procedures and triggers), import data from CSV and SQL, export data to various formats: CSV, SQL, XML, PDF, OpenDocument Text and Spreadsheet, Word, Excel, LATEX and others, administering multiple servers, creating PDF graphics of your database layout, creating complex queries using Query-by-example (QBE), searching globally in a database or a subset of it, transforming stored data into any format using a set of predefined functions, like displaying BLOB-data as image or download-link and much more... RHEL 5 is only shipping php-5.1.6-27.el5_5.3, but phpMyAdmin 3.x requires at least PHP 5.2 to work proper. But RHEL 5 also provides php53 packages since a few month. This package is intended only for RHEL 5.
This package is just a slightly modified version of phpMyAdmin which is already included in Fedora. It builds fine against the php53-extras stack and works fine on Centos 5/x86_64. What I would like is to clarify the Provides section. With the proposed spec, the package now gives: [wolfy@wolfy result]$ rpm -qp --provides /var/lib/mock/epel-5-x86_64/result/phpMyAdmin3-3.4.3.2-2.el5.noarch.rpm config(phpMyAdmin3) = 3.4.3.2-2.el5 phpMyAdmin = 3.4.3.2-2.el5 phpmyadmin = 3.4.3.2-2.el5 phpMyAdmin3 = 3.4.3.2-2.el5 Is it really intended to provide both phpMyAdmin and the lowercase version of the name ? If so, why the change, as phpMyAdmin ( vers. 2.11.11) only has the following provides: config(phpMyAdmin) = 2.11.11.3-1.el5 phpmyadmin phpMyAdmin = 2.11.11.3-1.el5
The lowercase provides exists to work around broken 3rd party software, which is mostly from 3rd party repositories. I thought the unversioned provides is fixed with the latest package in epel-testing, but I might be wrong here. The other provides are automagically generated by RPM.
You are correct, the unversioned provides no longer exists in 2.11.11.3-2. My installed version was the one from stable. I had/have no objections about providing both the lowercase and uppercase versions of the name, I just wanted to be sure that this in intended and not an oversight. What I foresee as an issue is the fact that both phpMyAdmin and phpMyAdmin3 will both provide phpMyAdmin. And according to my local tests, the following happen (please also see the 2 attached logs): [root@pc68 ~]# yum provides --showduplicates phpMyAdmin --enablerepo=epel-testing Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: ftp.ines.lug.ro * epel: ftp.ines.lug.ro * epel-testing: ftp.ines.lug.ro * extras: ftp.ines.lug.ro * updates: ftp.ines.lug.ro epel-testing | 3.7 kB 00:00 epel-testing/primary_db | 234 kB 00:00 phpMyAdmin-2.11.11.3-1.el5.noarch : Web based MySQL browser written in php Repo : epel Matched from: phpMyAdmin3-3.4.3.2-2.el5.noarch : Handle the administration of MySQL over the World Wide Web Repo : nobugcustom Matched from: Other : phpMyAdmin phpMyAdmin-2.11.11.3-2.el5.noarch : Handle the administration of MySQL over the World Wide Web Repo : epel-testing Matched from:
Created attachment 516696 [details] normal install output from yum install phpMyAdmin
Created attachment 516697 [details] forced install of phpMyAdmin3 output of yum install phpMyAdmin3
I'm fine with the showduplicates output of yum. The installation examples from comment #4 and #5 are as expected from my point of view.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: el5/x86_64 [x] Rpmlint output: phpMyAdmin.src: W: spelling-error %description -l en_US phpMyAdmin -> sysadmin, administer, badminton phpMyAdmin.src: E: invalid-spec-name phpMyAdmin.src:334: W: macro-in-%changelog %{_datadir} phpMyAdmin.src: W: invalid-url Source0: http://downloads.sourceforge.net/sourceforge/phpMyAdmin/phpMyAdmin-3.4.4-all-languages.tar.bz2 HTTP Error 302: The HTTP server returned a redirect error that would lead to an infinite loop. The last 30x error message was: Found => Apparently there is an issue with the way SF.net manages links now. phpMyAdmin3-3.4.4-1.el5.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type : GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of source file: 48af9356c9dbeb45b3062560b535de30af9a7dd4 phpMyAdmin-3.4.4-all-languages.tar.bz2 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissible content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final provides and requires are sane. === SUGGESTED ITEMS === [?] Latest version is packaged. I assume you will do it anyway but please make sure to push 3.4.4 ( already in rawhide and tested above ) instead of 3.4.3.2 which was submitted for review [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: EPEL5/x86_64 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: EPEL5/x86_64 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the test passes. === Final Notes === Can be installed and works fine in Centos 5/x86_64 + EPEL ================ *** APPROVED *** ================
Manuel, thank you very much for the review. New Package SCM Request ======================= Package Name: phpMyAdmin3 Short Description: Handle the administration of MySQL over the World Wide Web Owners: robert Branches: el5 InitialCC:
Git done (by process-git-requests).
phpMyAdmin3-3.4.4-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/phpMyAdmin3-3.4.4-1.el5
Package phpMyAdmin3-3.4.4-1.el5: * should fix your issue, * was pushed to the Fedora EPEL 5 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing phpMyAdmin3-3.4.4-1.el5' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/phpMyAdmin3-3.4.4-1.el5 then log in and leave karma (feedback).
phpMyAdmin3-3.4.4-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.