Bug 726393 - unique uses deprecated G_CONST_RETURN
Summary: unique uses deprecated G_CONST_RETURN
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: unique
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-28 13:34 UTC by Michel Alexandre Salim
Modified: 2011-07-28 14:21 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-28 14:21:57 UTC
Type: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Michel Alexandre Salim 2011-07-28 13:34:08 UTC 
Description of problem:

unique 1.1.6 uses G_CONST_RETURN, for example in /usr/include/unique-1.0/unique/uniquemessage.h -- this has now been removed from the GLib in F-16 and Rawhide, causing compilation failure when rebuilding xnoise (and likely other packages)

Version-Release number of selected component (if applicable):
unique-1.1.6-5.fc16

How reproducible:
Always

Steps to Reproduce:
1. fedpkg clone xnoise
2. cd xnoise && fedpkg scratch-build --target=dist-f16

see e.g. http://koji.fedoraproject.org/koji/getfile?taskID=3235535&name=build.log

Actual results:
Build fails:

In file included from /usr/include/unique-1.0/unique/uniqueapp.h:26:0,
                 from /usr/include/unique-1.0/unique/unique.h:24,
                 from Utils/xnoise-app-starter.c:36:
/usr/include/unique-1.0/unique/uniquemessage.h:51:1: error: unknown type name 'G_CONST_RETURN'

Expected results:
Build should pass (as it does on F-15 and below)

Additional info:
Comment 1 Michel Alexandre Salim 2011-07-28 13:34:58 UTC 
btw, the URL field in the spec should probably be changed to point to http://live.gnome.org/LibUnique
Comment 2 Michel Alexandre Salim 2011-07-28 13:38:38 UTC 
Ah, unique3 is probably needed. Should unique be blocked in F-16 and Rawhide, then?
Comment 3 Michel Alexandre Salim 2011-07-28 14:21:57 UTC 
removing -DG_DISABLE_DEPRECATED from the relevant Makefile fixes this; not a bug. Apologies.
Note You need to log in before you can comment on or make changes to this bug.