Bug 726486 - Review Request: verne-backgrounds - Verne desktop backgrounds
Summary: Review Request: verne-backgrounds - Verne desktop backgrounds
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ian Weller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-07-28 19:32 UTC by Martin Sourada
Modified: 2011-08-02 03:54 UTC (History)
3 users (show)

Fixed In Version: desktop-backgrounds-16.0.0-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-02 03:54:59 UTC
Type: ---
ian: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Martin Sourada 2011-07-28 19:32:05 UTC
Spec URL: http://mso.fedorapeople.org/packages/SPECS/verne-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/verne-backgrounds-15.91.0-1.fc15.src.rpm
Description: This package contains desktop backgrounds for the Verne theme.

Additional info: reused spec from previous releases, dangling symlinks are ok. Commented-out things are preparations for expected Supplemental wallpapers.

Comment 1 Ian Weller 2011-07-28 19:57:12 UTC
[  OK  ] specfiles match:
  fbeab392a2ab1727d33d983f6f4a5cc5  verne-backgrounds.spec
  fbeab392a2ab1727d33d983f6f4a5cc5  verne-backgrounds.spec.1
[  OK  ] source files match upstream:
  76e4d55069ff014a81c3ee4b919284f2  verne-backgrounds-15.91.0.tar.xz
  76e4d55069ff014a81c3ee4b919284f2  verne-backgrounds-15.91.0.tar.xz.1
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present.
[  OK  ] package builds in mock.
  scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3236394
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
  (only no-documentation and dangling-relative-symlink warnings, these are fine)
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates.
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  N/A ] no headers.
[  N/A ] no pkgconfig files.
[  N/A ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

-----------------------------------------------------------
 This package (verne-backgrounds) is APPROVED by ianweller
-----------------------------------------------------------

Comment 2 Martin Sourada 2011-07-28 19:59:26 UTC
New Package SCM Request
=======================
Package Name: verne-backgrounds
Short Description: Verne desktop backgrounds
Owners: mso
Branches: F-16
InitialCC:

Comment 3 Gwyn Ciesla 2011-07-28 22:17:13 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-07-29 08:06:35 UTC
desktop-backgrounds-16.0.0-1.fc16,verne-backgrounds-15.91.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/desktop-backgrounds-16.0.0-1.fc16,verne-backgrounds-15.91.0-1.fc16

Comment 5 Fedora Update System 2011-08-02 03:54:54 UTC
desktop-backgrounds-16.0.0-1.fc16, verne-backgrounds-15.91.0-1.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.