Hide Forgot
Spec URL: http://sdz.fedorapeople.org/rpmbuild/mimelib.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/mimelib-1.1.4-1.fc15.src.rpm Description: This is for lurker!
[ OK ] specfiles match: d645381e46de5b12a9b91285cd0dce11 mimelib.spec d645381e46de5b12a9b91285cd0dce11 mimelib.spec.1 [ OK ] source files match upstream: faee9a08b96a1c62a33ce79915797474 mimelib1_1.1.4.orig.tar.gz faee9a08b96a1c62a33ce79915797474 mimelib1_1.1.4.orig.tar.gz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ N/A ] %clean is present. Based on the relevant guideline that you shouted to me across the room, this is okay that it is not present *but* if you ever get this built for EL5 or less %clean does need to be present. [ OK ] package builds in mock. http://koji.fedoraproject.org/koji/taskinfo?taskID=3242344 [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ OK ] rpmlint is silent. (only errors are spelling errors which is ridiculous) [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers not in -devel. [ OK ] no pkgconfig files not in -devel. [ OK ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. ------------------------------------------------- This package (mimelib) is APPROVED by ianweller -------------------------------------------------
Sebastian, do you plan on getting this into Fedora?
No, but feel free to do so!
Then it'll need a re-review, so I'm closing this ticket.