Bug 730038 (perl-Child) - Review Request: perl-Child - Object oriented simple interface to fork()
Summary: Review Request: perl-Child - Object oriented simple interface to fork()
Alias: perl-Child
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Mario Blättermann
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Child/
Depends On:
TreeView+ depends on / blocked
Reported: 2011-08-11 15:36 UTC by Iain Arnell
Modified: 2011-08-26 19:12 UTC (History)
3 users (show)

Fixed In Version: perl-Child-0.009-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-08-23 20:35:25 UTC
mario.blaettermann: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Iain Arnell 2011-08-11 15:36:29 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Child.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Child-0.009-1.fc15.src.rpm

Fork is too low level, and difficult to manage. Often people forget to exit
at the end, reap their children, and check exit status. The problem is the
low level functions provided to do these things. Throw in pipes for IPC and
you just have a pile of things nobody wants to think about.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3266193


Comment 1 Mario Blättermann 2011-08-12 18:33:43 UTC
$ rpmlint -i -v *rpm
perl-Child.src: I: checking
perl-Child.src: I: checking-url http://search.cpan.org/dist/Child/ (timeout 10 seconds)
perl-Child.src: I: checking-url http://search.cpan.org/CPAN/authors/id/E/EX/EXODIST/Child-0.009.tar.gz (timeout 10 seconds)
perl-Child.noarch: I: checking
perl-Child.noarch: I: checking-url http://search.cpan.org/dist/Child/ (timeout 10 seconds)
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

No issues so far. Stay tuned for a full review.

Comment 2 Mario Blättermann 2011-08-12 18:43:44 UTC

[+] OK
[.] OK, not applicable
[X] needs work

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    41cb73572a4015c43d17beeaffc83fc0  Child-0.009.tar.gz
    41cb73572a4015c43d17beeaffc83fc0  Child-0.009.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    I assume the packager has tested it. Don't know how to test it on my
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.




Comment 3 Iain Arnell 2011-08-13 06:21:52 UTC
New Package SCM Request
Package Name: perl-Child
Short Description: Object oriented simple interface to fork()
Owners: iarnell
Branches: f14 f15 f16
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2011-08-13 14:37:48 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2011-08-14 06:23:05 UTC
perl-Child-0.009-1.fc16 has been submitted as an update for Fedora 16.

Comment 6 Fedora Update System 2011-08-14 06:23:13 UTC
perl-Child-0.009-1.fc15 has been submitted as an update for Fedora 15.

Comment 7 Fedora Update System 2011-08-14 06:23:21 UTC
perl-Child-0.009-1.fc14 has been submitted as an update for Fedora 14.

Comment 8 Fedora Update System 2011-08-15 20:24:58 UTC
perl-Child-0.009-1.fc16 has been pushed to the Fedora 16 testing repository.

Comment 9 Fedora Update System 2011-08-23 20:35:19 UTC
perl-Child-0.009-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 10 Fedora Update System 2011-08-26 18:50:37 UTC
perl-Child-0.009-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 11 Fedora Update System 2011-08-26 19:12:42 UTC
perl-Child-0.009-1.fc14 has been pushed to the Fedora 14 stable repository.

Note You need to log in before you can comment on or make changes to this bug.