Spec URL: http://fedorapeople.org/~iarnell/review/perl-DateTime-Format-Epoch.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-DateTime-Format-Epoch-0.13-1.fc17.src.rpm Description: This module can convert a DateTime object (or any object that can be converted to a DateTime object) to the number of seconds since a given epoch. It can also do the reverse. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3266232 *rt-0.10_01
New Koji scratch build (for yours no files available anymore): http://koji.fedoraproject.org/koji/taskinfo?taskID=3307303 $ rpmlint -i -v * perl-DateTime-Format-Epoch.noarch: I: checking perl-DateTime-Format-Epoch.noarch: I: checking-url http://search.cpan.org/dist/DateTime-Format-Epoch/ (timeout 10 seconds) perl-DateTime-Format-Epoch.noarch: E: incorrect-fsf-address /usr/share/doc/perl-DateTime-Format-Epoch-0.13/LICENSE The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. perl-DateTime-Format-Epoch.src: I: checking perl-DateTime-Format-Epoch.src: I: checking-url http://search.cpan.org/dist/DateTime-Format-Epoch/ (timeout 10 seconds) perl-DateTime-Format-Epoch.src: I: checking-url http://www.cpan.org/modules/by-module/DateTime/DateTime-Format-Epoch-0.13.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Just an old FSF address, no further issues. You might drop the LICENSE from files, because the package is licensed under the common Perl terms anyway. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * f42982ea634401df953f88ce5eec1b7d DateTime-Format-Epoch-0.13.tar.gz f42982ea634401df953f88ce5eec1b7d DateTime-Format-Epoch-0.13.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ----------------
(In reply to comment #1) > > Just an old FSF address, no further issues. You might drop the LICENSE from > files, because the package is licensed under the common Perl terms anyway. Already reported upstream. https://rt.cpan.org/Ticket/Display.html?id=70227 I can't simply drop it - licensing guidelines require that "If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc" Thanks, as ever, for the review.
New Package SCM Request ======================= Package Name: perl-DateTime-Format-Epoch Short Description: Convert DateTimes to/from epoch seconds Owners: iarnell Branches: f14 f15 f16 InitialCC: perl-sig
Git done (by process-git-requests).
perl-DateTime-Format-Epoch-0.13-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-DateTime-Format-Epoch-0.13-1.fc15
perl-DateTime-Format-Epoch-0.13-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-DateTime-Format-Epoch-0.13-1.fc16
perl-DateTime-Format-Epoch-0.13-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-DateTime-Format-Epoch-0.13-1.fc14
perl-DateTime-Format-Epoch-0.13-1.fc16 has been pushed to the Fedora 16 testing repository.
perl-DateTime-Format-Epoch-0.13-1.fc16 has been pushed to the Fedora 16 stable repository.
perl-DateTime-Format-Epoch-0.13-1.fc14 has been pushed to the Fedora 14 stable repository.
perl-DateTime-Format-Epoch-0.13-1.fc15 has been pushed to the Fedora 15 stable repository.