RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 730600 - Bugfix: Check stdoutWatch before removing the handler.
Summary: Bugfix: Check stdoutWatch before removing the handler.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Daniel Veillard
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-08-15 03:10 UTC by Daniel Veillard
Modified: 2011-12-06 11:26 UTC (History)
4 users (show)

Fixed In Version: libvirt-0.9.4-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 11:26:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1513 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2011-12-06 01:23:30 UTC

Description Daniel Veillard 2011-08-15 03:10:05 UTC
Description of problem: correct a file descriptor allocation bug reported and
fixed upstream ed009313b166da9fd077758a21aa9a328209e7f1

@@ -95,7 +95,7 @@ virConsoleShutdown(virConsolePtr con)
         virStreamFree(con->st);
     if (con->stdinWatch != -1)
         virEventRemoveHandle(con->stdinWatch);
-    if (con->stdinWatch != -1)
+    if (con->stdoutWatch != -1)
         virEventRemoveHandle(con->stdoutWatch);
     con->stdinWatch = -1;
     con->stdoutWatch = -1;



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 3 Alex Jia 2011-08-16 06:59:31 UTC
Libvirt indeed should check stdoutWatch before removing the handler, I can see this fix in libvirt-0.9.4-4.el6.src.rpm and current libvirt upstream:

# git show ed009313b166da9fd077758a21aa9a328209e7f1
commit ed009313b166da9fd077758a21aa9a328209e7f1
Author: Juerg Haefliger <juerg.haefliger>
Date:   Wed Aug 10 17:03:23 2011 +0200

    Bugfix: Check stdoutWatch before removing the handler.

diff --git a/tools/console.c b/tools/console.c
index 11087e5..171ebc9 100644
--- a/tools/console.c
+++ b/tools/console.c
@@ -95,7 +95,7 @@ virConsoleShutdown(virConsolePtr con)
         virStreamFree(con->st);
     if (con->stdinWatch != -1)
         virEventRemoveHandle(con->stdinWatch);
-    if (con->stdinWatch != -1)
+    if (con->stdoutWatch != -1)
         virEventRemoveHandle(con->stdoutWatch);
     con->stdinWatch = -1;
     con->stdoutWatch = -1;

Hence, change the bug status to VERIFIED.

Comment 4 errata-xmlrpc 2011-12-06 11:26:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html


Note You need to log in before you can comment on or make changes to this bug.