Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
There's an element of "don't do that" here. Verbose mode is for debugging, and one possible error an administrator may do is mistype a password.
The easiest thing to do is remove the feedback for what fence_ipmilan is forking.
(In reply to comment #5)
> user can see the password typed from command line so there is no reason to log
> it even in verbose mode.
Users are not restricted to calling fencing agents from the command line to debug configurations (and in fact, they rarely do), so this argument does not really apply.
It's better to change the output than not; I've attached a patch that changes it to "[set]" in what is printed instead of the password contents.
Patch is now in upstream:
http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=61a7bb3addd3862833f5cf23725d378c563a10c5
Unit test:
Befora applying patch:
./fence_ipmilan -o status -a dell-ipmi -l root -p PASS -v
Getting status of
IPMI:dell-ipmi...Spawning:
'/usr/bin/ipmitool -I lan -H 'dell-ipmi' -U 'root' -P 'PASS' -v
chassis power status'...
Chassis power = On
Done
After applying patch:
./fence_ipmilan -o status -a dell-ipmi -l root -p PASS -v
Getting status of
IPMI:dell-ipmi...Spawning:
'/usr/bin/ipmitool -I lan -H 'dell-ipmi' -U 'root' -P '[set]' -v
chassis power status'...
Chassis power = On
Done
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2011-1599.html