Spec URL: http://kalev.fedorapeople.org/esteid-browser-plugin.spec SRPM URL: http://kalev.fedorapeople.org/esteid-browser-plugin-1.3.0-1.fc15.src.rpm Description: esteid-browser-plugin is cross-browser plugin exposing Estonian eID card's digital signing functions in JavaScript. Digital signing is a common operation on Estonian electronic bank sites. To protect privacy, the plugin only allows access for web sites in an editable whitelist.
I'll take a look.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3291943 $ rpmlint *.rpm esteid-browser-plugin.src: W: spelling-error %description -l en_US eID -> ID, CID, e ID esteid-browser-plugin.src: W: spelling-error %description -l en_US whitelist -> white list, white-list, Whiteley esteid-browser-plugin.src: W: invalid-url Source1: http://esteid.googlecode.com/files/esteid-browser-plugin-1.3.0.tar.bz2 HTTP Error 404: Not Found esteid-browser-plugin.src: W: invalid-url Source0: http://firebreath.googlecode.com/files/firebreath-1.5.2.tar.bz2 HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 4 warnings. mostly harmless sources: ok $ md5sum *.bz2 174ba07a9adf4a8419db8aa47bf33ecb esteid-browser-plugin-1.3.0.tar.bz2 14e5854f90655f87eddf6d0d5f735f46 firebreath-1.5.2.tar.bz2 license: MUST: please review from my quick looking over, most of the code seems to be dual-licensed: BSD or LGPLv2 log4cplus is apache (not sure if that's actually used in the build.. yet) naming: ok though I have some reservations about the combining of 2 tarball/projects into one package here, but perhaps that's the upstream design here (i'm not familiar with it enough to judge). if so, please do add a comment in the .spec to make that clear. macros: ok scriptlets: n/a
Thanks for the review, Rex! (In reply to comment #2) > license: MUST: please review > from my quick looking over, most of the code seems to be dual-licensed: BSD or > LGPLv2 Added a comment in the spec file explaining the dual-licensing. > log4cplus is apache (not sure if that's actually used in the build.. yet) I'm just going to remove the bundled libraries, including log4cplus, in %prep. That way we can be sure that they aren't getting used and it is easier to analyze licensing. > naming: ok > though I have some reservations about the combining of 2 tarball/projects > into one package here, but perhaps that's the upstream design here (i'm > not familiar with it enough to judge). if so, please do add a comment in > the .spec to make that clear. Done. * Mon Aug 22 2011 Kalev Lember <kalevlember> - 1.3.0-2 - Added a comment explaining the multiple licensing breakdown and the reason for split tarballs (#732419) - Remove bundled libraries in prep Spec URL: http://kalev.fedorapeople.org/esteid-browser-plugin.spec SRPM URL: http://kalev.fedorapeople.org/esteid-browser-plugin-1.3.0-2.fc15.src.rpm
Thanks, looks good to me now. APPROVED.
New Package SCM Request ======================= Package Name: esteid-browser-plugin Short Description: Estonian ID card digital signing browser plugin Owners: kalev Branches: f14 f15 f16 InitialCC: sander85
Git done (by process-git-requests).
Package imported and built; closing the ticket.