Spec URL: http://tflink.fedorapeople.org/packages/python-yourls/python-yourls.spec SRPM URL: http://tflink.fedorapeople.org/packages/python-yourls/python-yourls-0.1.1-1.fc15.src.rpm Description: Simple Python client for the YOURLS [1] URL shortener [1] http://yourls.org/
I'll take this, comments to follow shortly.
Good: - rpmlint checks return: Invalid license tag, is GPL2+, should be GPLv2+ - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Everything's good but the license tag. I'm running a mock build o\to test BRs, so that's pending as well.
BRs are fine, it's just the license tag.
Gah, simple mistakes. Uploaded fixed spec and SRPM http://tflink.fedorapeople.org/packages/python-yourls/python-yourls.spec http://tflink.fedorapeople.org/packages/python-yourls/python-yourls-0.1.1-1.fc15.src.rpm
> http://tflink.fedorapeople.org/packages/python-yourls/python-yourls-0.1.1-1.fc15.src.rpm Copy/paste fail: http://tflink.fedorapeople.org/packages/python-yourls/python-yourls-0.1.1-2.fc15.src.rpm
Is there anything else that needs to be done on my end to get the review wrapped up?
Wow. No, just go back in time and make me see the BZ email for your comments. Sorry for the delay. APPROVED.
New Package SCM Request ======================= Package Name: python-yourls Short Description: Simple Python client for the YOURLS URL shortener Owners: tflink mkrizek Branches: f15 f16 el6 InitialCC:
Git done (by process-git-requests).
Built some time ago.