Bug 733895 - tarfile.extractall overwrites normal files and directories, yet it fails to overwrite symlinks
Summary: tarfile.extractall overwrites normal files and directories, yet it fails to o...
Alias: None
Product: Fedora
Classification: Fedora
Component: python
Version: 14
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dave Malcolm
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2011-08-28 11:50 UTC by Tomas Winkler
Modified: 2012-08-16 13:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-08-16 13:08:24 UTC

Attachments (Terms of Use)

System ID Priority Status Summary Last Updated
Python 10761 None None None Never

Description Tomas Winkler 2011-08-28 11:50:34 UTC
Description of problem:

Currently packaged python 2.7 contains bug described in http://bugs.python.org/issue10761. And it's hitting me hard in my scripts.

tarfile.extractall overwrites normal files and directories, yet it fails to overwrite symlinks:

Version-Release number of selected component (if applicable):
Name        : python
Version     : 2.7
Release     : 8.fc14.1 

How reproducible:


Steps to Reproduce:
# test_tarfile.py
# Description:
#       tests for python tarfile module
# $Id$

import os
import shutil
import tarfile
import tempfile

def test_tar_overwrites_symlink():
    d = tempfile.mkdtemp()
        new_dir_name = os.path.join(d, 'newdir')
        archive_name = os.path.join(d, 'newdir.tar')
        source_file_name = os.path.join(new_dir_name, 'source')
        target_link_name = os.path.join(new_dir_name, 'symlink')
        with open(source_file_name, 'w') as f:
        os.symlink(source_file_name, target_link_name)
        with tarfile.open(archive_name, 'w') as tar:
            for f in [source_file_name, target_link_name]:
                tar.add(f, arcname=os.path.basename(f))
        # this should not raise OSError: [Errno 17] File exists
        with tarfile.open(archive_name, 'r') as tar:
Actual results:
OSError: [Errno 17] File exists

Expected results:
no output

Additional info:
Bug was fixed. 

Comment 1 Fedora End Of Life 2012-08-16 13:08:27 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 

Note You need to log in before you can comment on or make changes to this bug.