Bug 737335 - [BACKEND] VM dynamic table contains unused columns that should be removed.
Summary: [BACKEND] VM dynamic table contains unused columns that should be removed.
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: x86_64
OS: Linux
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Vinzenz Feenstra [evilissimo]
QA Contact: Israel Pinto
Depends On:
TreeView+ depends on / blocked
Reported: 2011-09-11 07:45 UTC by Yaniv Lavi
Modified: 2016-04-20 01:29 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-04-20 01:29:06 UTC
oVirt Team: Virt
Target Upstream Version:

Attachments (Terms of Use)

System ID Priority Status Summary Last Updated
oVirt gerrit 35505 master MERGED Remove unused columns guest_last_log{in,out}_time from database Never

Description Yaniv Lavi 2011-09-11 07:45:06 UTC
Description of problem:
VM dynamic table contains unused columns that should be removed. 
These columns are:
vm_last_up_time, vm_last_boot_time, guest_cur_user_id, guest_last_login_time, guest_last_logout_time

Version-Release number of selected component (if applicable):

How reproducible:
always[BACKEND] VM dynamic table contains

Comment 1 Itamar Heim 2012-12-11 06:42:53 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.

Comment 2 Yaniv Lavi 2012-12-12 09:42:35 UTC
Still relevant reopening.


Comment 5 Itamar Heim 2014-01-05 10:14:53 UTC
I think last_up_time is used now.
not sure about the rest.
michal - is this planned for 3.4?

Comment 6 Michal Skrivanek 2014-01-07 07:49:37 UTC
aren't the guest_* fields in use as well?

Comment 7 Vinzenz Feenstra [evilissimo] 2014-01-07 08:10:00 UTC
(In reply to Michal Skrivanek from comment #6)
> aren't the guest_* fields in use as well?

The only value currently really in use is guest_last_login_time and even that seems questionable.

Comment 9 Michal Skrivanek 2014-08-22 13:01:36 UTC
this bug won't fit into 3.5 release and is being deferred to a later release. If you deeply care about this bug and deserves to be re-evaluated please let me know

Comment 10 Vinzenz Feenstra [evilissimo] 2015-03-05 07:37:35 UTC
Merged to upstream master

Comment 11 Israel Pinto 2015-04-30 14:24:38 UTC
Verify with 3.6:
oVirt Engine Version: 3.6.0-0.0.master.20150412172306.git55ba764.el6
Steps to check:
1. Connect DB on engine:
su - postgres
psql engine
2. View vm_dynamic table columns:
engine-# \d+ vm_dynamic
3. Check that the columns(vm_last_up_time, vm_last_boot_time, guest_cur_user_id, guest_last_login_time, guest_last_logout_time) not appear in table

All the request columns are removed

Note You need to log in before you can comment on or make changes to this bug.