Hide Forgot
Spec URL: http://pwu.fedorapeople.org/libpinyin/libpinyin.spec SRPM URL: http://pwu.fedorapeople.org/libpinyin/libpinyin-0.2.99.1-1.fc15.src.rpm Description: The libpinyin project aims to provide the algorithms core for intelligent sentence-based Chinese pinyin input methods.
Review: + koji build for f16->http://koji.fedoraproject.org/koji/taskinfo?taskID=3384522 + rpmlint output is libpinyin-devel.x86_64: W: no-documentation libpinyin-devel.x86_64: E: incorrect-fsf-address /usr/include/libpinyin-0.3/pinyin_custom.h libpinyin-devel.x86_64: E: incorrect-fsf-address /usr/include/libpinyin-0.3/novel_types.h libpinyin-devel.x86_64: E: incorrect-fsf-address /usr/include/libpinyin-0.3/pinyin_base.h libpinyin-devel.x86_64: E: incorrect-fsf-address /usr/include/libpinyin-0.3/pinyin.h libpinyin-data.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 4 errors, 2 warnings. + source verified with upstream as (sha1sum) 83e39b3b2b229970bbf6e3dcc43d0e8786f56aa8 libpinyin-0.2.99.1.tar.gz 83e39b3b2b229970bbf6e3dcc43d0e8786f56aa8 ../SOURCES/libpinyin-0.2.99.1.tar.gz Suggestions: 1) Please ask the upstream to correct the FSF address as per reported in rpmlint output. 2) You don't need to clean buildroot in %install. Please remove that line in spec. 3) Good to use make command as make %{?_smp_mflags} 4) Good to preserve timestamps with following install command make install DESTDIR==$RPM_BUILD_ROOT INSTALL="install -p" APPROVED.
Thanks for reviewing.
New Package SCM Request ======================= Package Name: libpinyin Short Description: Library to deal with pinyin Owners: pwu Branches: f15 f16 InitialCC: i18n-team petersen
Git done (by process-git-requests).
libpinyin-0.2.99.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libpinyin-0.2.99.2-1.fc15
libpinyin-0.2.99.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libpinyin-0.2.99.2-1.fc16
libpinyin-0.2.99.2-1.fc16 has been pushed to the Fedora 16 testing repository.
libpinyin-0.2.99.2-1.fc15 has been pushed to the Fedora 15 stable repository.
libpinyin-0.2.99.2-1.fc16 has been pushed to the Fedora 16 stable repository.