Bug 742276 - /etc/init.d/network does not like names produced by NetworkManager
Summary: /etc/init.d/network does not like names produced by NetworkManager
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: initscripts
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 742273
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-09-29 15:01 UTC by Paolo Bonzini
Modified: 2014-03-17 03:28 UTC (History)
6 users (show)

Fixed In Version: initscripts-9.33-1.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-17 00:46:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
potential patch (667 bytes, patch)
2011-09-29 18:04 UTC, Bill Nottingham
no flags Details | Diff

Description Paolo Bonzini 2011-09-29 15:01:55 UTC
NetworkManager only escapes space, slash and backslash.

The network init script, instead, matches ifcfg files against ifcfg-[A-Za-z0-9#\._-]\+.  This causes a lot of confusion when network files contain other characters (typically for weird wireless SSIDs).

Actually, NetworkManager will also produce files with a space, but that's arguably a bug in NM rather than in the initscripts.  Still, I'm marking the space-in-filename bug as blocking this one.

Version-Release number of selected component (if applicable):
9.32

Comment 1 Paolo Bonzini 2011-09-29 15:02:47 UTC
Should have been "NetworkManager only escapes space, slash and backslash when transforming a network name into a file for /etc/sysconfig/network-scripts".

Comment 2 Bill Nottingham 2011-09-29 18:03:16 UTC
What happens if you just drop that match entirely?

Comment 3 Bill Nottingham 2011-09-29 18:04:17 UTC
Created attachment 525611 [details]
potential patch

Comment 4 Paolo Bonzini 2011-09-30 10:54:16 UTC
Looks good!

Comment 6 Fedora Update System 2011-10-12 21:12:36 UTC
initscripts-9.33-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/initscripts-9.33-1.fc16

Comment 7 Fedora Update System 2011-10-13 18:12:29 UTC
Package initscripts-9.33-1.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing initscripts-9.33-1.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-14259
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2011-10-17 00:46:01 UTC
initscripts-9.33-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.