Bug 742752 - Port virt-manager to gtk.Builder
Summary: Port virt-manager to gtk.Builder
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-02 13:18 UTC by Artur Frysiak
Modified: 2012-02-02 20:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-02 20:04:12 UTC

Attachments (Terms of Use)
python code ported to gtk.Builder (44.13 KB, patch)
2011-10-02 13:24 UTC, Artur Frysiak 		no flags Details | Diff
UI file converted to GtkBuilder (1.54 MB, patch)
2011-10-02 13:25 UTC, Artur Frysiak 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Artur Frysiak 2011-10-02 13:18:54 UTC 
virt-manager depends on gtk.glade, but this is deprecated and easy replaceable by gtk.Builder. 

This is first step to port virt-manager to gtk+ 3.x and pygobject3.
Comment 1 Artur Frysiak 2011-10-02 13:24:07 UTC 
Created attachment 525931 [details]
python code ported to gtk.Builder
Comment 2 Artur Frysiak 2011-10-02 13:25:12 UTC 
Created attachment 525932 [details]
UI file converted to GtkBuilder
Comment 3 Daniel Berrangé 2011-10-03 08:46:39 UTC 
NB, this removes the ability to run virt-manager on a RHEL-5 vintage OS, since GtkBuilder was first added in GTK 2.12.

That said, I believe this is an acceptable tradeoff at this point in time, since RHEL-5 is > 5 years old now. As an point of reference, the recent virt-viewer release has also dropped RHEL-5 support and now uses GtkBuilder
Comment 4 Cole Robinson 2012-02-02 20:04:12 UTC 
Hi Artur, thanks for the patches. Unfortunately they don't quite apply anymore, so I basically reimplemented it upstream. There were also quite a few hiccups in the conversion process as documented here:

https://www.redhat.com/archives/virt-tools-list/2012-February/msg00016.html

Either way, end result is upstream now uses gtkbuilder, so closing.
Note You need to log in before you can comment on or make changes to this bug.