Hide Forgot
PackageReview bugzilla for adding qpid-tools to RHEL 5
Relevant files: http://download.devel.redhat.com/brewroot/packages/qpid-tools/0.12/2.el6/src/qpid-tools-0.12-2.el6.src.rpm http://cvs.devel.redhat.com/cgi-bin/cvsweb.cgi/rpms/qpid-tools/RHEL-6/qpid-tools.spec?rev=HEAD;content-type=text%2Fplain
Reviewed as per the Fedora guidelines: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint qpid-tools-0.12-2.el6.src.rpm qpid-tools-0.12-2.noarch.rpm qpid-tools.src: W: non-standard-group Development/Python qpid-tools.src:36: W: macro-in-comment %patch1 qpid-tools.src:37: W: macro-in-comment %patch2 qpid-tools.src:38: W: macro-in-comment %patch3 qpid-tools.src:39: W: macro-in-comment %patch4 qpid-tools.src:40: W: macro-in-comment %patch5 qpid-tools.src: W: invalid-url Source0: qpid-tools-0.12.tar.gz qpid-tools.noarch: W: non-standard-group Development/Python qpid-tools.noarch: W: devel-file-in-non-devel-package /usr/bin/qpid-config qpid-tools.noarch: W: no-manual-page-for-binary qpid-config qpid-tools.noarch: W: no-manual-page-for-binary qpid-route qpid-tools.noarch: W: no-manual-page-for-binary qmf-tool qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster-store qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster qpid-tools.noarch: W: no-manual-page-for-binary qpid-tool qpid-tools.noarch: W: no-manual-page-for-binary qpid-stat qpid-tools.noarch: W: no-manual-page-for-binary qpid-queue-stats qpid-tools.noarch: W: no-manual-page-for-binary qpid-printevents 2 packages and 0 specfiles checked; 0 errors, 18 warnings. MUST: The package must be named according to the Package Naming Guidelines. - OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. - OK MUST: The package must meet the Packaging Guidelines. - OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. - OK MUST: The License field in the package spec file must match the actual license. - OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. - OK MUST: The spec file must be written in American English. - OK MUST: The spec file for the package MUST be legible. - OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. - see invalid URL warning above (plus, the svn checkout comments on the specfile are out of date). Maybe point directly to the official qpid tarfile at http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-tools-0.12.tar.gz I compared the md5sums against that URL, and they match: $ rpm2cpio qpid-tools-0.12-2.el6.src.rpm | cpio -ivd BZ688163.patch qpid-tools-0.12.tar.gz qpid-tools.spec 91 blocks $ md5sum qpid-tools-0.12.tar.gz 7a95f4dd9bb99396ac2e44b99e15b1f5 qpid-tools-0.12.tar.gz $ wget http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-tools-0.12.tar.gz --2011-10-10 18:51:33-- http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-tools-0.12.tar.gz Resolving www.apache.org... 140.211.11.131 Connecting to www.apache.org|140.211.11.131|:80... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/html] Saving to: “qpid-tools-0.12.tar.gz.1” [ <=> ] 27,262 134K/s in 0.2s 2011-10-10 18:51:33 (134 KB/s) - “qpid-tools-0.12.tar.gz.1” saved [27262] $ md5sum qpid-tools-0.12.tar.gz 7a95f4dd9bb99396ac2e44b99e15b1f5 qpid-tools-0.12.tar.gz MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - OK $ rpmbuild -ba qpid-tools.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.48464 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd /home/boston/nsantos/rpmbuild/BUILD + rm -rf qpid-tools-0.12 + /usr/bin/gzip -dc /home/boston/nsantos/rpmbuild/SOURCES/qpid-tools-0.12.tar.gz + tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd qpid-tools-0.12 ++ /usr/bin/id -u + '[' 3400 = 0 ']' ++ /usr/bin/id -u + '[' 3400 = 0 ']' + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + echo 'Patch #0 (BZ688163.patch):' Patch #0 (BZ688163.patch): + patch -p3 -s + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.66895 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd qpid-tools-0.12 + CFLAGS='-O2 -g -m64 -mtune=generic' + /usr/bin/python setup.py build running build running build_scripts creating build creating build/scripts-2.4 copying and adjusting src/py/qpid-cluster -> build/scripts-2.4 copying and adjusting src/py/qpid-cluster-store -> build/scripts-2.4 copying and adjusting src/py/qpid-config -> build/scripts-2.4 copying and adjusting src/py/qpid-printevents -> build/scripts-2.4 copying and adjusting src/py/qpid-queue-stats -> build/scripts-2.4 copying and adjusting src/py/qpid-route -> build/scripts-2.4 copying and adjusting src/py/qpid-stat -> build/scripts-2.4 copying and adjusting src/py/qpid-tool -> build/scripts-2.4 copying and adjusting src/py/qmf-tool -> build/scripts-2.4 changing mode of build/scripts-2.4/qpid-cluster from 644 to 755 changing mode of build/scripts-2.4/qpid-cluster-store from 644 to 755 changing mode of build/scripts-2.4/qpid-config from 644 to 755 changing mode of build/scripts-2.4/qpid-printevents from 644 to 755 changing mode of build/scripts-2.4/qpid-queue-stats from 644 to 755 changing mode of build/scripts-2.4/qpid-route from 644 to 755 changing mode of build/scripts-2.4/qpid-stat from 644 to 755 changing mode of build/scripts-2.4/qpid-tool from 644 to 755 changing mode of build/scripts-2.4/qmf-tool from 644 to 755 + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.66895 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd qpid-tools-0.12 + rm -rf /var/tmp/qpid-tools-0.12-2-root-nsantos + /usr/bin/python setup.py install --skip-build --root /var/tmp/qpid-tools-0.12-2-root-nsantos running install running install_scripts creating /var/tmp/qpid-tools-0.12-2-root-nsantos creating /var/tmp/qpid-tools-0.12-2-root-nsantos/usr creating /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-cluster -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-cluster-store -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-config -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-printevents -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-queue-stats -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-route -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-stat -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qpid-tool -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin copying build/scripts-2.4/qmf-tool -> /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-cluster to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-cluster-store to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-config to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-printevents to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-queue-stats to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-route to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-stat to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qpid-tool to 755 changing mode of /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/bin/qmf-tool to 755 + /usr/lib/rpm/brp-compress + /usr/lib/rpm/brp-strip + /usr/lib/rpm/brp-strip-static-archive + /usr/lib/rpm/brp-strip-comment-note Processing files: qpid-tools-0.12-2 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.66895 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd qpid-tools-0.12 + DOCDIR=/var/tmp/qpid-tools-0.12-2-root-nsantos/usr/share/doc/qpid-tools-0.12 + export DOCDIR + rm -rf /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/share/doc/qpid-tools-0.12 + /bin/mkdir -p /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/share/doc/qpid-tools-0.12 + cp -pr LICENSE.txt NOTICE.txt /var/tmp/qpid-tools-0.12-2-root-nsantos/usr/share/doc/qpid-tools-0.12 + exit 0 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/python python-qpid >= 0.12 python-qpid-qmf >= 0.12 Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/qpid-tools-0.12-2-root-nsantos Wrote: /home/boston/nsantos/rpmbuild/SRPMS/qpid-tools-0.12-2.src.rpm Wrote: /home/boston/nsantos/rpmbuild/RPMS/noarch/qpid-tools-0.12-2.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.89870 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd qpid-tools-0.12 + rm -rf /var/tmp/qpid-tools-0.12-2-root-nsantos + exit 0 MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. - N/A MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. - OK MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. - N/A MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. - N/A MUST: Packages must NOT bundle copies of system libraries. - OK MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. - N/A MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. - OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) - OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. - OK MUST: Each package must consistently use macros. - OK MUST: The package must contain code, or permissable content. - OK MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). - N/A MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. - OK MUST: Header files must be in a -devel package. - N/A MUST: Static libraries must be in a -static package. - N/A MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. - N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} - N/A MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. - OK MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. - N/A MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. - OK MUST: All filenames in rpm packages must be valid UTF-8. - OK SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. - N/A SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. - N/A SHOULD: The reviewer should test that the package builds in mock. - OK SHOULD: The package should compile and build into binary rpms on all supported architectures. - OK (noarch) SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. - OK (upstream testing before release) SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. - OK SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. - N/A SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. - N/A SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. - OK SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. - N/A ====================== The only significant issue is the one related to the URL to the upstream tarball. The warnings could be easily cleared up.
Updated Files: SRPM: http://tross.fedorapeople.org/qpid-tools-0.12-2.src.rpm SPEC: http://tross.fedorapeople.org/qpid-tools.spec
$ rpmlint qpid-tools-0.12-2.src.rpm qpid-tools-0.12-2.noarch.rpm qpid-tools.src: W: non-standard-group Development/Python qpid-tools.noarch: W: non-standard-group Development/Python qpid-tools.noarch: W: devel-file-in-non-devel-package /usr/bin/qpid-config qpid-tools.noarch: W: no-manual-page-for-binary qpid-config qpid-tools.noarch: W: no-manual-page-for-binary qpid-route qpid-tools.noarch: W: no-manual-page-for-binary qmf-tool qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster-store qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster qpid-tools.noarch: W: no-manual-page-for-binary qpid-tool qpid-tools.noarch: W: no-manual-page-for-binary qpid-stat qpid-tools.noarch: W: no-manual-page-for-binary qpid-queue-stats qpid-tools.noarch: W: no-manual-page-for-binary qpid-printevents 2 packages and 0 specfiles checked; 0 errors, 12 warnings. ==================== The URL has been fixed and the warnings look ok to bypass, so I'm approving the review, feel free to request the branch next.