Bug 744003 - a message should be logged once the Server is fully started, and commons-logging, rather than servlet API, should be used for logging in our servlets
Summary: a message should be logged once the Server is fully started, and commons-logg...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core Server
Version: 4.1
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: ---
: ---
Assignee: Ian Springer
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-06 18:02 UTC by Ian Springer
Modified: 2013-08-06 00:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-07 19:19:38 UTC


Attachments (Terms of Use)

Description Ian Springer 2011-10-06 18:02:42 UTC

Comment 1 Ian Springer 2011-10-06 18:12:15 UTC
[master 080f19a] takes care of this.

The message "RHQ x.x.x (build xxxxxxx) Server started." is now logged at INFO level once RHQ is done initializing (it's surrounded by two rows of dashes to make it more prominent), e.g.:

13:51:44,916 INFO  [MasterServerPluginContainer] Master server plugin container scheduled all jobs
13:51:44,917 INFO  [StartupServlet] Starting agent clients - any persisted messages with guaranteed delivery will be sent...
13:51:44,981 INFO  [StartupServlet] --------------------------------------------------
13:51:44,982 INFO  [StartupServlet] RHQ 4.1.0-SNAPSHOT (build ${buildNumber}) Server started.
13:51:44,982 INFO  [StartupServlet] --------------------------------------------------
13:51:46,621 INFO  [EARDeployer] Started J2EE application: file:/home/ips/Projects/rhq/dev-container/jbossas/server/default/deploy/rhq.ear/
13:51:46,765 INFO  [Http11Protocol] Starting Coyote HTTP/1.1 on http-0.0.0.0-7080
13:51:46,875 INFO  [Http11Protocol] Starting Coyote HTTP/1.1 on http-0.0.0.0-7443
13:51:46,893 INFO  [Server] JBoss (MX MicroKernel) [4.2.3.GA (build: SVNTag=JBoss_4_2_3_GA date=200807181417)] Started in 1m:48s:938ms
13:52:24,783 INFO  [CoreServerServiceImpl] Agent [jetengine][4.1.0-SNAPSHOT(${buildNumber})] would like to connect to this server
13:52:26,339 INFO  [CoreServerServiceImpl] Agent [jetengine] has connected to this server at Thu Oct 06 13:52:26 EDT 2011
13:52:26,396 INFO  [RtFilter] -- Filter openFile: Writing response-time log for webapp with context root 'jboss-remoting-servlet-invoker' to '/home/ips/Projects/rhq/dev-container/jbossas/server/default/log/rt/jboss-remoting-servlet-invoker_rt.log' (hashCode=1531685135)...


Also, commons-logging, rather than the servlet log() API, is now used by StartupServlet and our other servlets do do logging, so that messages can be logged at an appropriate category (previously even error messages were logged at INFO level) and formatted consistently with all other messages in the Server log. For example, the message:

13:51:44,917 INFO  [StartupServlet] Starting agent clients - any persisted messages with guaranteed delivery will be sent...

used to look like this:

13:51:44,917 INFO  [/] (StartupServlet) Starting agent clients - any persisted messages with guaranteed delivery will be sent...

Comment 2 Sunil Kondkar 2011-10-07 08:55:12 UTC
Verified on build#485 (Version: 4.1.0-SNAPSHOT Build Number: e07065d).

The server log displays below:

2011-10-07 14:13:28,591 INFO  [org.rhq.enterprise.gui.startup.StartupServlet] Starting agent clients - any persisted messages with guaranteed delivery will be sent...
2011-10-07 14:13:28,611 INFO  [org.rhq.enterprise.gui.startup.StartupServlet] --------------------------------------------------
2011-10-07 14:13:28,612 INFO  [org.rhq.enterprise.gui.startup.StartupServlet] RHQ 4.1.0-SNAPSHOT (build e07065d) Server started.
2011-10-07 14:13:28,612 INFO  [org.rhq.enterprise.gui.startup.StartupServlet] --------------------------------------------------
2011-10-07 14:13:29,471 INFO  [org.jboss.deployment.EARDeployer] Started J2EE application: file:/store/rhqbuilds/master/build485/rhq-server-4.1.0-SNAPSHOT/jbossas/server/default/deploy/rhq.ear/

Comment 3 Mike Foley 2012-02-07 19:19:38 UTC
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE


Note You need to log in before you can comment on or make changes to this bug.