Hide Forgot
Description of problem: Creating a disk snapshot with <disks> fails if VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY was not specified, although this should not be required if VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE is present. Version-Release number of selected component (if applicable): libvirt-0.9.4-14.el6 How reproducible: 100% Steps to Reproduce: 1. virsh start dom 2. virsh snapshot-create-as dom --disk-only snap 3. virsh snapshot-edit dom snap # try adding <description> Actual results: error: Failed to update snap error: argument unsupported: unable to handle disk requests in snapshot Expected results: While --disk-only is important for allowing <disks> when creating a new snapshot, modifying an existing snapshot should be smart enough to realize that it already existed with disks, and thus not error out. This needs to be fixed in both the qemu driver (avoid erroring out on redefine) and in virsh (communicating to 0.9.5 or 0.9.6 will encounter qemu that errors out, so virsh must scrape the xml and decide whether to add the disk-only flag). Additional info: Introduced by the resolution to bug 638510
Upstream patches proposed: https://www.redhat.com/archives/libvir-list/2011-October/msg00196.html
In POST: http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-October/msg00236.html
verify pass on qemu-kvm-0.12.1.2-2.195.el6.x86_64 kernel-2.6.32-206.el6.x86_64 libvirt-0.9.4-16.el6.x86_64 # virsh snapshot-edit qcow2 snap Snapshot snap edited.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1513.html