Bug 744492 - Review Request: rtmidi - Library for realtime MIDI input/output
Summary: Review Request: rtmidi - Library for realtime MIDI input/output
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 710917
TreeView+ depends on / blocked
 
Reported: 2011-10-09 01:34 UTC by Robin Lee
Modified: 2011-10-25 03:26 UTC (History)
3 users (show)

Fixed In Version: rtmidi-1.0.15-2.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-25 03:26:50 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Robin Lee 2011-10-09 01:34:43 UTC
Spec URL: http://cheeselee.fedorapeople.org/rtmidi.spec
SRPM URL: http://cheeselee.fedorapeople.org/rtmidi-1.0.15-2.fc15.src.rpm
Description:
RtMidi is a set of C++ classes (RtMidiIn and RtMidiOut) that provides a common 
API (Application Programming Interface) for realtime MIDI input/output across 
Linux (ALSA & Jack), Macintosh OS X, Windows (Multimedia Library), and SGI 
operating systems. RtMidi significantly simplifies the process of interacting 
with computer MIDI hardware and software. It was designed with the following 
goals:
* object oriented C++ design
* simple, common API across all supported platforms
* only two header files and one source file for easy inclusion in programming 
  projects
* MIDI device enumeration

Comment 1 Tom "spot" Callaway 2011-10-11 14:39:44 UTC
== REVIEW ==
rpmlint output:
rtmidi.src: W: spelling-error Summary(en_US) realtime -> mealtime, real time, real-time
rtmidi.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time
rtmidi.x86_64: W: spelling-error Summary(en_US) realtime -> mealtime, real time, real-time
rtmidi.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time
rtmidi-jack.x86_64: W: spelling-error Summary(en_US) realtime -> mealtime, real time, real-time
rtmidi-jack.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (b1aaa6ff72e1385a7a29b4a2ab60c49863663bdf8c55bac93d548aacc8b6bc56)
- package compiles on f16 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base packages n-v-r 

APPROVED. Nice work with the patching, hopefully upstream will take it.

Comment 2 Robin Lee 2011-10-11 16:29:56 UTC
Thank you!

New Package SCM Request
=======================
Package Name: rtmidi
Short Description: Library for realtime MIDI input/output
Owners: cheeselee
Branches: f15 f16
InitialCC:

Comment 3 Gwyn Ciesla 2011-10-11 16:36:16 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-10-12 02:34:06 UTC
rtmidi-1.0.15-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/rtmidi-1.0.15-2.fc16

Comment 5 Fedora Update System 2011-10-13 18:13:01 UTC
rtmidi-1.0.15-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 6 Fedora Update System 2011-10-25 03:26:50 UTC
rtmidi-1.0.15-2.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.