Bug 745304 - email tag followed by punctuation results in an extra space that cannot be removed
Summary: email tag followed by punctuation results in an extra space that cannot be re...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 2.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 3.0
Assignee: Jeff Fearn 🐞
QA Contact: Ruediger Landmann
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-12 00:33 UTC by Murray McAllister
Modified: 2015-01-04 22:36 UTC (History)
6 users (show)

Fixed In Version: 3.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-10-31 03:10:56 UTC


Attachments (Terms of Use)
Patch to restore mixed mode on email tag (1.11 KB, patch)
2012-04-29 12:57 UTC, Raphaël Hertzog
no flags Details | Diff

Description Murray McAllister 2011-10-12 00:33:34 UTC
Description of problem:

Not sure if this can be fixed in Publican. If punctuation (I only tried : and
,) is used after the email tag, a space is added that cannot be removed.

Version-Release number of selected component (if applicable):
publican-2.7-1
firefox-3.6.23-2.el6_1.x86_64
Red Hat Enterprise Linux Workstation release 6.1 (Santiago)

How reproducible:
Always, for me.

Steps to Reproduce:
1. use a . or a : after an email tag, for example:

Email <email>this</email>. to

End of the line <email>another</email>.(\n)

2. Build with the common brand in the txt, html, html-single, and pdf formats.

Actual results:
Email this . to

End of the line another .

Expected results:
Email this. to

End of the line another.

Comment 1 Jeff Fearn 🐞 2011-10-12 00:47:00 UTC
No newline after email when inline!

Applied fix to branches/publican-2x and trunk.

Committed revision 1917.

Comment 2 Laura Novich 2012-04-24 12:12:02 UTC
I put the lines into another document, and the problem still exists

Comment 3 Raphaël Hertzog 2012-04-25 20:47:07 UTC
I have a similar problem with the git version of 27th march of this year. So whatever was the fix that got committed, it's not enough yet.

In my case, I saw it in a build of a translation. And the problem is really that it inserts a spurious newline but also tabs to indent the content.

Comment 4 Raphaël Hertzog 2012-04-29 12:57:15 UTC
Created attachment 581063 [details]
Patch to restore mixed mode on email tag

Please find attached a patch that fixes the issue by restoring the mixed_mode attribute that was present in publican 2.9 but was lost in publican 3.0.

Comment 5 Jeff Fearn 🐞 2012-05-17 02:57:23 UTC
Confirm mixed_mode lost during code merge.

Patch applied.

To ssh://git.fedorahosted.org/git/publican.git
   5000dcf..2e04033  master -> master

Comment 6 Michael Hideo 2012-06-08 01:45:04 UTC
create book, include body text that is inside an email tag. follow the email tag with punctuation, build book, hope that ther eis no space between email tag and punctuation.

Comment 7 Stephen Gordon 2012-06-08 15:57:47 UTC
Verified on publican-3.0-0.fc17.t179, in both PDF and HTML formats extra space is no longer inserted in output between <email>...</email> tags and following punctuation.


Note You need to log in before you can comment on or make changes to this bug.