Hide Forgot
Spec URL: http://v3.sk/~xyzz/rpm/perl-RT-Authen-ExternalAuth.spec SRPM URL: http://v3.sk/~xyzz/rpm/perl-RT-Authen-ExternalAuth-0.09-2.fc14.src.rpm Description: A complete package for adding external authentication mechanisms to RT. It currently supports LDAP via Net::LDAP and External Database authentication for any database with an installed DBI driver.
- builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3430712 - rpmlint silent
$ rpmlint -i -v * perl-RT-Authen-ExternalAuth.src: I: checking perl-RT-Authen-ExternalAuth.src: I: checking-url http://search.cpan.org/dist/RT-Authen-ExternalAuth/ (timeout 10 seconds) perl-RT-Authen-ExternalAuth.src: I: checking-url http://www.cpan.org/authors/id/F/FA/FALCONE/RT-Authen-ExternalAuth-0.09.tar.gz (timeout 10 seconds) perl-RT-Authen-ExternalAuth.noarch: I: checking perl-RT-Authen-ExternalAuth.noarch: I: checking-url http://search.cpan.org/dist/RT-Authen-ExternalAuth/ (timeout 10 seconds) perl-RT-Authen-ExternalAuth.spec: I: checking-url http://www.cpan.org/authors/id/F/FA/FALCONE/RT-Authen-ExternalAuth-0.09.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. No issues. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [X] MUST: The package must be licensed with a Fedora approved license. GPLv2 [X] MUST: The License field in the package spec file must match the actual license. According to the README file, the license is GPLv2. There's no hint about re-licensing under newer GPL versions. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 3089dbad24538fd51492bb881062219d RT-Authen-ExternalAuth-0.09.tar.gz 3089dbad24538fd51492bb881062219d RT-Authen-ExternalAuth-0.09.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts.
(In reply to comment #2) > $ rpmlint -i -v * > perl-RT-Authen-ExternalAuth.src: I: checking > perl-RT-Authen-ExternalAuth.src: I: checking-url > http://search.cpan.org/dist/RT-Authen-ExternalAuth/ (timeout 10 seconds) > perl-RT-Authen-ExternalAuth.src: I: checking-url > http://www.cpan.org/authors/id/F/FA/FALCONE/RT-Authen-ExternalAuth-0.09.tar.gz > (timeout 10 seconds) > perl-RT-Authen-ExternalAuth.noarch: I: checking > perl-RT-Authen-ExternalAuth.noarch: I: checking-url > http://search.cpan.org/dist/RT-Authen-ExternalAuth/ (timeout 10 seconds) > perl-RT-Authen-ExternalAuth.spec: I: checking-url > http://www.cpan.org/authors/id/F/FA/FALCONE/RT-Authen-ExternalAuth-0.09.tar.gz > (timeout 10 seconds) > 2 packages and 1 specfiles checked; 0 errors, 0 warnings. > > No issues. > > > --------------------------------- > key: > > [+] OK > [.] OK, not applicable > [X] needs work > --------------------------------- > > [+] MUST: The package must be named according to the Package Naming Guidelines. > [+] MUST: The spec file name must match the base package %{name}. > [+] MUST: The package must meet the Packaging Guidelines. > [X] MUST: The package must be licensed with a Fedora approved license. > GPLv2 > [X] MUST: The License field in the package spec file must match the actual > license. > According to the README file, the license is GPLv2. There's no hint about > re-licensing under newer GPL versions. The bundled LICENSE file, as referenced from README in "COPYRIGHT AND LICENCE" paragraph, says: This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. Which in fact is GPLv2+.
(In reply to comment #3) > The bundled LICENSE file, as referenced from README in "COPYRIGHT AND LICENCE" > paragraph, says: > > This program is free software; you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > the Free Software Foundation; either version 2 of the License, or > (at your option) any later version. > > Which in fact is GPLv2+. OK, I wasn't aware of this. ---------------- PACKAGE APPROVED ----------------
I'm interested in using this (on F16). Michal, do you have any immediate plans to request builds and release the package ? Alternatively, are you interested in a co-maintainer ? :) Thanks, --Gabriel
Hi Gabriel, sorry for late response. I will post SCM admin request today, and put you there as co-maintainer. Also update package to current 0.10 release. Would that be OK? :)
(In reply to comment #6) > Hi Gabriel, > sorry for late response. I will post SCM admin request today, and put you there > as co-maintainer. Also update package to current 0.10 release. Would that be > OK? :) Excellent -- Thanks !
New Package SCM Request ======================= Package Name: perl-RT-Authen-ExternalAuth Short Description: RT Authentication using External Sources Owners: ksyz somlo Branches: f16 f17 el5 el6
Git done (by process-git-requests).
I imported rawhide, F17, F16, and EL6 packages. Rawhide currently fails to build due to some sort of httpd-mmn related breakage, but will probably build fine once that's sorted out. Regarding EL5 -- the RT version shipping there is 3.6.11, which only works with perl-RT-Authen-ExternalAuth versions up to 0.05 (see http://cpansearch.perl.org/src/TSIBLEY/RT-Authen-ExternalAuth-0.10/README under VERSION NOTES). Michal, do you think it's worth packaging 0.05 for EL-5, or should we simply just stick with supporting 0.10+ on EL-6+ and F-16+ ? Thanks, --Gabriel
(In reply to comment #10) > I imported rawhide, F17, F16, and EL6 packages. Rawhide currently fails to > build > due to some sort of httpd-mmn related breakage, but will probably build fine > once > that's sorted out. Thanks, great. > Regarding EL5 -- the RT version shipping there is 3.6.11, which only works with > perl-RT-Authen-ExternalAuth versions up to 0.05 (see > http://cpansearch.perl.org/src/TSIBLEY/RT-Authen-ExternalAuth-0.10/README > under VERSION NOTES). > > Michal, do you think it's worth packaging 0.05 for EL-5, or should we simply > just stick with supporting 0.10+ on EL-6+ and F-16+ ? I don't think it's worth it, because I consider EL5 to be a legacy system right now, so people probably already installed this package (and also current RT) from CPAN. All those branches were requested just in case. If someone is willing to maintain that branch, they are encouraged to request acls.
I'm willing to take the EL5 branch. fwiw, the latest release that builds on EL5 is 0.08 and it seems to work fine despite what the notes say. I've requested ACLs in the pkgdb.
Can anyone please kindly grant me access to the EL5 branch ?
Michal, Gabriel, can you please grant me access to the EL5 branch ? https://admin.fedoraproject.org/pkgdb/acls/name/perl-RT-Authen-ExternalAuth
(In reply to comment #13) > Can anyone please kindly grant me access to the EL5 branch ? Done. Btw, if you are willing to co-maintain, feel free to ask for other acls.
I finally managed to get a successful build in f18 (now that mod-perl is happy).