Bug 746320 - ActivateStorageDomain.canDoAction can return failure message when it succeeds
Summary: ActivateStorageDomain.canDoAction can return failure message when it succeeds
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.1
Assignee: Jon Choate
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-14 18:31 UTC by Jon Choate
Modified: 2012-08-09 08:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-09 08:04:22 UTC
oVirt Team: ---

Attachments (Terms of Use)
test to reproduce (3.14 KB, text/x-java)
2011-10-14 18:31 UTC, Jon Choate 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Jon Choate 2011-10-14 18:31:55 UTC 
Created attachment 528257 [details]
test to reproduce

Description of problem:

If you attempt to activate a storage domain that has a status if Unknown and canDoAction succeeds, canDoAction messages will still contain a message that the status is invalid.  This is due to the fact that we have multiple calls to CheckStorageDomainStatus.


How reproducible:
Any time the status is unknown or its locked and internal execution


Steps to Reproduce:
1. Run the attached test

  
Actual results:
CanDoActionsMessages contains the string ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL

Expected results:
no failure messages in CanDoActionMessages

Additional info:
Comment 2 Jon Choate 2011-12-08 13:24:16 UTC 
Fixed by

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=8fb35d6fb99ff51a1a50b682233c9649087b6ffd
Comment 3 Itamar Heim 2012-08-09 08:04:22 UTC 
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/
Note You need to log in before you can comment on or make changes to this bug.