Spec URL: http://domsch.com/fedora/python-passlib/python-passlib.spec SRPM URL: http://domsch.com/fedora/python-passlib/python-passlib-1.5.3-1.src.rpm Description: Passlib is a password hashing library for Python 2 & 3, which provides cross-platform implementations of over 20 password hashing algorithms, as well as a framework for managing existing password hashes. It's designed to be useful for a wide range of tasks, from verifying a hash found in /etc/shadow, to providing full-strength password hashing for multi-user application.
domsch.com is horked, so I put them at http://mdomsch.fedorapeople.org/python-passlib/
The spec file is missing a BuildRequires of python-setuptools. With that change it does build.
Spec URL: http://www.princeton.edu/~knight/fedora/python-passlib.spec SRPM URL: http://www.princeton.edu/~knight/fedora/python-passlib-1.5.3-1.src.rpm rpmlint output: http://www.princeton.edu/~knight/fedora/rpmlint.txt Only change was the addition of the BuildRequires and rerunning rpmlint.
Robert's version looks good to me. rpmlint passes, packaging looks sane. Licensing is correct. Installs fine and sample code from docs on website works. I'd like to see these 3 minor things fixed up before or after importing: 1. Let's do what the comment says: # Remove CFLAGS=... for noarch packages (unneeded) 2. Don't need 'rm -rf %{buildroot}' in %install: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 3. Don't need to define %{python_sitelib} anymore: http://fedoraproject.org/wiki/Packaging:Python#Macros APPROVED
Corrected at the URL's in Comment 3.
New Package SCM Request ======================= Package Name: python-passlib Short Description: Comprehensive password hashing framework Owners: mdomsch Branches: f16 el6 InitialCC:
Git done (by process-git-requests). Mark, please take ownership of review BZs. Thanks!
python-passlib-1.5.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-passlib-1.5.3-1.fc16
python-passlib-1.5.3-1.fc16 has been pushed to the Fedora 16 testing repository.
python-passlib-1.5.3-1.fc16 has been pushed to the Fedora 16 stable repository.