Bug 747211 - Anyone can add system Key/Values
Summary: Anyone can add system Key/Values
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Beaker
Classification: Retired
Component: inventory
Version: 0.7
Hardware: Unspecified
OS: Unspecified
low
unspecified vote
Target Milestone: ---
Assignee: beaker-dev-list
QA Contact:
URL:
Whiteboard: Misc
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-19 05:32 UTC by Raymond Mancy
Modified: 2020-10-21 14:15 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-21 14:15:55 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Raymond Mancy 2011-10-19 05:32:51 UTC 
We currently don't restrict who can add Key/Values to a system, we just hide the 'Add' button. We should add something like:-

  system.can_admin(user)

into def save_keys()
Comment 1 Marian Csontos 2011-10-19 07:42:30 UTC 
Is that a bug or a feature?

Majority of keys should be locked, but we could have a "namespace" (prefix?) available for regular users - see Bug 602912.
Comment 2 Raymond Mancy 2011-10-19 22:33:48 UTC 
The intent of the interface would make me think it's a bug.
Comment 3 Marian Csontos 2011-10-20 05:17:22 UTC 
Yes, I mean bug, but an useful one, often called "undocumented feature".

This could be turned into full fledged feature, but for now it should be fixed I think.
Note You need to log in before you can comment on or make changes to this bug.