Bug 748536 - [PATCH] Build with gpm and liblockfile, update php-mode, drop ssl.el
Summary: [PATCH] Build with gpm and liblockfile, update php-mode, drop ssl.el
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: emacs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karel Klíč
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-24 17:59 UTC by Ville Skyttä
Modified: 2013-03-03 23:03 UTC (History)
3 users (show)

Fixed In Version: 23.3-11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-07 15:50:38 UTC
Type: ---

Attachments (Terms of Use)
Mentioned improvements (1.98 KB, patch)
2011-10-24 17:59 UTC, Ville Skyttä 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Ville Skyttä 2011-10-24 17:59:55 UTC 
Created attachment 529936 [details]
Mentioned improvements

Attached is a patch with some improvements to emacs:

1) Build with gpm support - improves console mouse experience.  This should be done at least for -nox, but I don't think it's a problem with the X build so the patch does it for both.

2) Build with liblockfile support.  This affects movemail which I admit I've never used, but either support for liblockfile (and etpan which is its fallback) should be built or explicitly disabled for reproducible builds.

3) php-mode updated to 1.5.0 (should IMO also be moved to lookaside cache instead of being in git - unchanging basename between releases is not a problem).

4) ssl.el dropped, AFAIK tls.el has long since replaced it.

Want me to push and build this for devel?
Comment 1 Jonathan Underwood 2011-10-25 09:53:08 UTC 
php-mode should really be moved into its own package.
Comment 2 Karel Klíč 2011-11-07 11:44:12 UTC 
Ville, the changes look good. Thank you. Feel free to push and build.

> php-mode should really be moved into its own package.

Jonathan, yes, it should. I have created a php-mode spec file, and I'm going to open a review request for that.

Spec URL: http://kklic.fedorapeople.org/emacs-php-mode.spec
SRPM URL: http://kklic.fedorapeople.org/emacs-php-mode-1.5.0-1.fc14.src.rpm
Comment 3 Karel Klíč 2011-11-07 12:51:51 UTC 
Bug #751749 - Review Request: emacs-php-mode - Major GNU Emacs mode for editing PHP code
Note You need to log in before you can comment on or make changes to this bug.