zita-at1 is an autotuner, normally used to correct the pitch of a voice singing (slightly) out of tune. Depends on clxclient also under review: Bug 749753 SRPM: http://bsjones.fedorapeople.org/zita-at1-0.2.3-1.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/zita-at1.spec rpmlint /home/bsjones/rpmbuild/RPMS/x86_64/zita-at1* zita-at1.x86_64: W: spelling-error Summary(en_US) autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.x86_64: W: spelling-error %description -l en_US autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.x86_64: W: no-manual-page-for-binary zita-at1 2 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint /home/bsjones/rpmbuild/SRPMS/zita-at1* zita-at1.src: W: spelling-error Summary(en_US) autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.src: W: spelling-error %description -l en_US autotuner -> auto tuner, auto-tuner, autoimmune 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
SRPM: http://bsjones.fedorapeople.org/zita-at1-0.2.3-2.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/zita-at1.spec Added desktop file, remove unnecessary constructs from spec file.
I'll try do to this later today or tomorrow. Initial remarks: - keeping the -sse flag might be in conflict with [1]. It will break on x86_32 machines without sse, and on x86_64 you are guaranteed to have sse2 IIRC. - make sure to send Patch0 upstream, preferably making a note in the spec file [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
No problem, the flag removal for PPC should not have been there - removed, and commented sources/patch. Thanks SRPM: http://bsjones.fedorapeople.org/zita-at1-0.2.3-3.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/zita-at1.spec
Two more issues: 1. there is still --ffast-math in the CPPFLAGS which might violate the guidelines. I am not 100% sure on this, though. 2. BR: desktop-file-utils is missing, package does not build in mock.
I took a liberty of adding desktop-file-utils to move this forward: * rpmlint output OK: $ rpmlint zita-at1.spec /var/lib/mock/fedora-16-x86_64/result/*rpm zita-at1.src: W: spelling-error Summary(en_US) autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.src: W: spelling-error %description -l en_US autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.x86_64: W: spelling-error Summary(en_US) autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.x86_64: W: spelling-error %description -l en_US autotuner -> auto tuner, auto-tuner, autoimmune zita-at1.x86_64: W: no-manual-page-for-binary zita-at1 3 packages and 1 specfiles checked; 0 errors, 5 warnings. * Naming guidelines followed * spec file naming correct: zita-at1.spec * Packaging guidelines - use of --ffast-math violates [1] - BR: desktop-file-utils is missing [2] * Licensing is correct: GPLv2+ * License tag matches the actual license * COPYING file is included in %doc * spec file is written in American English * spec file is legible * source matches upstream: d901f378da09407b550c72b2607cc97f zita-at1-0.2.3.tar.bz2 * package does not build - BR: desktop-file-utils is missing * ExcludeArch: unable to test * BuildRequires: desktop-file-utils is missing * locales do not apply * there are no shared libraries * there are no copies of system libs bundled * package is not relocatable * directory ownership is correct * there are no duplicate files * permissions are correct * macros consistency: - please replace zita-at1 in Source1 and Patch0 with %{name} * package contains code * documentation is not big enough to warrant a -doc subpackage * there are no header files, static nor dynamic libraries * there are no subpackages * there are no libtool archives * there is a desktop file correctly installed with desktop-file-install * there are no overlapping ownerships * filenames are UTF-8 Summary: * use of --ffast-math violates [1]. Either remove it or provide rationale on why is it needed. * BR: desktop-file-utils is missing [2] * please replace zita-at1 in Source1 and Patch0 with %{name} Once these issues are resolved, I'll approve the package. [1] https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags [2] https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
Thanks Julia, have been away on business and will complete this and your over the next 2 days.
Thanks Julian, have made changes as requested, updated SPEC and SRPM: SRPM: http://bsjones.fedorapeople.org/zita-at1-0.2.3-4.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/zita-at1.spec
Comments have been addressed, this package is ACCEPTED.
New Package SCM Request ======================= Package Name: zita-at1 Short Description: autotuner for JACK Owners: bsjones Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
zita-at1-0.2.3-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/zita-at1-0.2.3-4.fc16
zita-at1-0.2.3-4.fc16 has been pushed to the Fedora 16 testing repository.
zita-at1-0.2.3-4.fc16 has been pushed to the Fedora 16 stable repository.
zita-at1-0.2.3-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/zita-at1-0.2.3-4.fc15
zita-at1-0.2.3-4.fc15 has been pushed to the Fedora 15 stable repository.