Bug 752185 - cluster glue includes glib headers - new glib generates a #error when glib.h isn't the only header included
Summary: cluster glue includes glib headers - new glib generates a #error when glib.h ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cluster-glue
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Andrew Beekhof
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-08 18:48 UTC by Steven Dake
Modified: 2016-04-27 04:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-12 05:12:11 UTC
Type: ---


Attachments (Terms of Use)

Description Steven Dake 2011-11-08 18:48:12 UTC
Description of problem:
one of the headers in cluster glue uses a glib header.  This results in errors with the latest glib.

Version-Release number of selected component (if applicable):
rawhide fedpkg build

How reproducible:
100%

Steps to Reproduce:
1. fedpkg build the pacemaker-cloud master repo
2.
3.
  
Actual results:
g++ -DHAVE_CONFIG_H -I.   -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -Iorg/pacemakercloud -I/usr/include/libxml2     -g -O2 -MT cped-cpe_agent.o -MD -MP -MF .deps/cped-cpe_agent.Tpo -c -o cped-cpe_agent.o `test -f 'cpe_agent.cpp' || echo './'`cpe_agent.cpp
In file included from /usr/include/clplumbing/cl_uuid.h:19:0,
                 from /usr/include/heartbeat/ha_msg.h:29,
                 from /usr/include/pacemaker/crm/common/xml.h:30,
                 from /usr/include/pacemaker/crm/msg_xml.h:302,
                 from /usr/include/pacemaker/crm/transition.h:20,
                 from pe_test.c:27:
/usr/include/glib-2.0/glib/gtypes.h:28:2: error: #error "Only <glib.h> can be included directly."
make[3]: *** [pe_test-pe_test.o] Error 1

Expected results:
cl_uuid.h only includes glib.h rather then other headers related to glib.

Additional info:

Comment 1 Andrew Beekhof 2011-12-12 04:58:30 UTC
I for one welcome our new aFewThingsYouWantandaMetricCraptonneYouDont.h overlords. 

I'll push this into rawhide shortly.


---
 include/clplumbing/cl_uuid.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: include/clplumbing/cl_uuid.h
===================================================================
--- include/clplumbing/cl_uuid.h.orig	2010-07-15 22:54:56.000000000 +1000
+++ include/clplumbing/cl_uuid.h	2011-12-12 15:52:09.498251710 +1100
@@ -16,7 +16,7 @@
 
 #ifndef _CL_UUID_H_
 #define _CL_UUID_H_
-#include <glib/gtypes.h>
+#include <glib.h>
 
 typedef struct cl_uuid_s{	
 	unsigned char	uuid[16];

Comment 2 Andrew Beekhof 2011-12-12 05:12:11 UTC
Done:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=3578792

Comment 3 Steven Dake 2011-12-12 14:32:06 UTC
Thanks andrew

Regards
-steve


Note You need to log in before you can comment on or make changes to this bug.