Bug 753583 - Review Request: gedit-code-assistance - gedit plugin for code assistance for C, C++ and Objective-C
Summary: Review Request: gedit-code-assistance - gedit plugin for code assistance for ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Elad Alfassa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-13 16:04 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2011-11-29 10:04 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-29 10:04:02 UTC
Type: ---
Embargoed:
elad: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ignacio Casal Quinteiro (nacho) 2011-11-13 16:04:37 UTC
Spec URL: http://people.gnome.org/~icq/gedit-code-assistance.spec
SRPM URL: http://people.gnome.org/~icq/gedit-code-assistance-0.1.1-1.fc16.src.rpm
Description: gedit code assistance is a plugin for gedit which provides code assistance for C, C++ and Objective-C by utilizing clang.

Comment 1 Ignacio Casal Quinteiro (nacho) 2011-11-13 16:05:16 UTC
Here is the rpmlint output:

nacho@ansalon:~/checkout/fedora$ rpmlint gedit-code-assistance.spec ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/RPMS/x86_64/gedit-code-assistance-debuginfo-0.1.1-1.fc16.x86_64.rpm ~/rpmbuild/SRPMS/gedit-code-assistance-0.1.1-1.fc16.src.rpm 
gedit-code-assistance.x86_64: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C
gedit-code-assistance.src: W: summary-not-capitalized C gedit plugin for code assistance for C, C++ and Objective-C
3 packages and 1 specfiles checked; 0 errors, 2 warnings.

These warnings are fine as it is gedit and not Gedit.

Comment 2 Ignacio Casal Quinteiro (nacho) 2011-11-13 16:19:47 UTC
And here is the build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3511303

Comment 3 Elad Alfassa 2011-11-16 11:00:02 UTC
I will review this.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 4 Elad Alfassa 2011-11-16 11:09:08 UTC
Package looks good, although it makes gedit crash every time I open some C files, and it doesn't work as intended with other C files.
I would like to debug this further before approving the package.

Comment 5 Ignacio Casal Quinteiro (nacho) 2011-11-16 11:11:21 UTC
There have been quite some important fixes upstream, not yet released but that we will release soon.

Comment 6 Ignacio Casal Quinteiro (nacho) 2011-11-19 18:11:03 UTC
Just released 0.1.2 and updated spec same link and the srpm in:
http://people.gnome.org/~icq/gedit-code-assistance-0.1.2-1.fc16.src.rpm

Comment 7 Elad Alfassa 2011-11-27 14:50:01 UTC
Seems fine to me, package is APPROVED.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 8 Ignacio Casal Quinteiro (nacho) 2011-11-27 16:23:05 UTC
New Package SCM Request
=======================
Package Name: gedit-code-assistance
Short Description: gedit plugin for code assistance for C, C++ and Objective-C
Owners: nacho
Branches: f16
InitialCC:

Comment 9 Gwyn Ciesla 2011-11-27 21:59:05 UTC
Git done (by process-git-requests).

Comment 10 Ignacio Casal Quinteiro (nacho) 2011-11-29 10:04:02 UTC
Built for f16. Closing the bug. Thanks to all of you.


Note You need to log in before you can comment on or make changes to this bug.